Re: [PATCH] gdb/python/python-internal.h: avoid uninitialized constexpr

[Lancelot SIX <Lancelot.Six@amd.com>]

On 18/06/2024 17:17, Tom Tromey wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
>>>>>> "Lancelot" == Lancelot SIX <lancelot.six@amd.com> writes:
> 
> Lancelot>  template<typename T>
> Lancelot> -constexpr char gdbpy_method_format;
> Lancelot> +struct gdbpy_method_format {};
> 
> Would it work to just remove the 'constexpr' from this line?
> 
> Tom

Just gave a try to this approach, I end up linker errors regarding 
duplicated symbols:

ld.lld: error: duplicate symbol: gdbpy_method_format<long long>
 >>> defined at python-internal.h:154 
(../../gdb/python/python-internal.h:154)
 >>>            python/py-arch.o:(gdbpy_method_format<long long>)
 >>> defined at python-internal.h:154 
(../../gdb/python/python-internal.h:154)
 >>>            python/py-auto-load.o:(.data+0x0)

ld.lld: error: duplicate symbol: gdbpy_method_format<unsigned long long>
 >>> defined at python-internal.h:157 
(../../gdb/python/python-internal.h:157)
 >>>            python/py-arch.o:(gdbpy_method_format<unsigned long long>)
 >>> defined at python-internal.h:157 
(../../gdb/python/python-internal.h:157)
 >>>            python/py-auto-load.o:(.data+0x20)

I have not really looked if there is a way to work-around that.

Best,
Lancelot.