From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id STtJHzZ/rWg3nwwAWB0awg (envelope-from ) for ; Tue, 26 Aug 2025 05:32:38 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=XxpvWdxk; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=gIMaWxHx; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=XxpvWdxk; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=gIMaWxHx; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 77EDB1E048; Tue, 26 Aug 2025 05:32:38 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_LOW,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 58AF11E043 for ; Tue, 26 Aug 2025 05:32:37 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DD459384C2C3 for ; Tue, 26 Aug 2025 09:32:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DD459384C2C3 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=XxpvWdxk; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=gIMaWxHx; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=XxpvWdxk; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=gIMaWxHx Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id BEC4C385B535 for ; Tue, 26 Aug 2025 09:31:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BEC4C385B535 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BEC4C385B535 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1756200718; cv=none; b=tWv0Vq4iJuiyoih9jyH6p8tNIZfw9nSc2p6bf0aIEqZtg6qakxWY4wmXjZxFAfP0qwCWJLVir4COKM/5hImQfc/Cx4EGYlgPL0rEs7abgP7ynrwU43fQKm/U+J+n6eNKMKoIzPzCB1jDb2cX1cWJf6+jfASA6y8kGae/vYJSzjQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1756200718; c=relaxed/simple; bh=hKpEsJBwGIxgrHDC89lgqWzbt/UmFbXYqrx6nNYPCaA=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=qHaSQQkmrh2Pn52jrXjDN3C7Ww3wQWWTgSAxM4U7OofhUI2Qt0c64/FXkRau9tJGXEWL1hQsuz+8YUNGWGlIyzCXsKnGSZhv/p3rVoAjO5BbqJYoKIoTVcFKIo6+xZreorfszZIkp1Q5n0gsaQ1u9Qsiju0H5YcORHGNzRnCV9Q= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BEC4C385B535 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id AB2561F449; Tue, 26 Aug 2025 09:31:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1756200717; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aqJpbhMCs4kVsr5U6tk9BncH82wx1Th/DHDWEBtyPy4=; b=XxpvWdxkInbNb8w4YF0ThvviHmqEQdZlhdEitfRAHnygvxJ+CtTnXtPjWnxtGl5bumAzX5 Xf9HI4Hpj5r/uaVs/Ihm7Ibt7pUKAhtQiBVSobA6s3cinnoQLuVk5mw1V97AyuZqcUEpKW mgr1G3CvpKVNd4W8YPpNBZO2hwgXVZ0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1756200717; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aqJpbhMCs4kVsr5U6tk9BncH82wx1Th/DHDWEBtyPy4=; b=gIMaWxHxVcU+rM5Xw6Himy8u9g/mzOufZAMOYA80JV5G3FvvQRqYfCfkPipiYmCsQBUZ/3 Z4aCk/gNwvKajHAg== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1756200717; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aqJpbhMCs4kVsr5U6tk9BncH82wx1Th/DHDWEBtyPy4=; b=XxpvWdxkInbNb8w4YF0ThvviHmqEQdZlhdEitfRAHnygvxJ+CtTnXtPjWnxtGl5bumAzX5 Xf9HI4Hpj5r/uaVs/Ihm7Ibt7pUKAhtQiBVSobA6s3cinnoQLuVk5mw1V97AyuZqcUEpKW mgr1G3CvpKVNd4W8YPpNBZO2hwgXVZ0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1756200717; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aqJpbhMCs4kVsr5U6tk9BncH82wx1Th/DHDWEBtyPy4=; b=gIMaWxHxVcU+rM5Xw6Himy8u9g/mzOufZAMOYA80JV5G3FvvQRqYfCfkPipiYmCsQBUZ/3 Z4aCk/gNwvKajHAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 607FB13479; Tue, 26 Aug 2025 09:31:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id eCwVFg1/rWhoYgAAD6G6ig (envelope-from ); Tue, 26 Aug 2025 09:31:57 +0000 Message-ID: <23021f8f-e769-4160-8689-24b9d38b61b6@suse.de> Date: Tue, 26 Aug 2025 11:31:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Inconsistent usage on onebyte_modrm and twobyte_modrm table in x86 disassembler and gdb? To: "Gerlicher, Klaus" , Sam James , "Beulich, Jan" Cc: "Jiang, Haochen" , Binutils , "gdb-patches@sourceware.org" , "H.J.Lu" , Alexander Monakov References: <92aea037-9c0e-438f-8a0a-fd52dd2df7bc@suse.com> <87v7mbrdqn.fsf@gentoo.org> Content-Language: en-US From: Tom de Vries In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-1.80 / 50.00]; BAYES_HAM(-3.00)[99.99%]; SUSPICIOUS_RECIPS(1.50)[]; SUBJECT_ENDS_QUESTION(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; TAGGED_RCPT(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[intel.com,sourceware.org,gmail.com,ispras.ru]; RCPT_COUNT_SEVEN(0.00)[8]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo, insn.data:url, suse.de:email, suse.de:mid] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 8/26/25 10:19, Gerlicher, Klaus wrote: > FWIW I'll attach my fix for the (V)PBLENDW. It has a testcase and a unittest case. Hi Klaus, thanks for working on this. The patch LGTM, other than this: ... $ git show --pretty=%s --check Fix vpblendw gdb/amd64-tdep.c:1409: space before tab in indent. + need_modrm = 1; ... I've tested both the unit test, and the updated test-case. I've also tested the unit test I wrote, which uses vex3 instead of evex: ... + + /* INSN: vpblendw $0x7,%xmm4,%xmm6,%xmm2, vex3 prefix. */ + insn = { 0xc4, 0xe3, 0x49, 0x0e, 0xd4, 0x07 }; + amd64_get_insn_details (insn.data (), &details); + SELF_CHECK (details.opcode_len == 3); + SELF_CHECK (details.enc_prefix_offset == 0); + SELF_CHECK (details.opcode_offset == 3); + SELF_CHECK (details.modrm_offset == 4); + + /* INSN: vpblendw $0x7,0xff(%rip),%ymm6,%ymm2, vex3 prefix. */ + insn = { 0xc4, 0xe3, 0x4d, 0x0e, 0x15, 0xff, 0x00, 0x00, 0x00, 0x07 }; + amd64_get_insn_details (insn.data (), &details); + SELF_CHECK (details.opcode_len == 3); + SELF_CHECK (details.enc_prefix_offset == 0); + SELF_CHECK (details.opcode_offset == 3); + SELF_CHECK (details.modrm_offset == 4); + + /* INSN: vpblendw $0x7,0xff(%ecx),%ymm6,%ymm2, vex3 prefix. */ + fixup_riprel (details, insn.data (), ECX_REG_NUM); + updated_insn + = { 0xc4, 0xe3, 0x4d, 0x0e, 0x91, 0xff, 0x00, 0x00, 0x00, 0x07 }; + SELF_CHECK (insn == updated_insn); ... You could add this as well, but it's not required. [ Note that you could drop the test-case update and use fixup_riprel on the unit test you added instead, like I did here and is done elsewhere in the unit test. ] Please commit this with some appropriate $subject. Approved-By: Tom de Vries Thanks, - Tom