From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79034 invoked by alias); 6 May 2016 11:49:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 79024 invoked by uid 89); 6 May 2016 11:49:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=factories X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 06 May 2016 11:49:23 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 216ED80096; Fri, 6 May 2016 11:49:22 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u46BnKFk022205; Fri, 6 May 2016 07:49:21 -0400 Subject: Re: [PATCH v2 04/25] Introduce interpreter factories To: Yao Qi References: <1458573675-15478-1-git-send-email-palves@redhat.com> <1458573675-15478-5-git-send-email-palves@redhat.com> <86zitqvqlo.fsf@gmail.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <22fe6899-0d63-4c76-a36a-290e363bd04a@redhat.com> Date: Fri, 06 May 2016 11:49:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <86zitqvqlo.fsf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-05/txt/msg00091.txt.bz2 Finally getting back to this... On 03/22/2016 08:55 AM, Yao Qi wrote: > Pedro Alves writes: > >> +void >> +interp_factory_register (const char *name, interp_factory_func func) >> +{ >> + struct interp_factory *f = XNEW (struct interp_factory); >> + >> + f->name = name; >> + f->func = func; >> + >> + /* FIXME: assert that no factory for NAME is already registered. */ >> + VEC_safe_push (interp_factory_p, interpreter_factories, f); >> +} > > It shouldn't be hard to do the assert here, and get rid of the FIXME. > Indeed. I fixed this for v3. Thanks, Pedro Alves