Re: [RFA] Fix leak by using td_ta_delete() to deregister target process and deallocate internal process handle.

[Pedro Alves <palves@redhat.com>]

On 12/07/2018 08:34 PM, Philippe Waroquiers wrote:

>  
> +static const char *thread_db_err_str (td_err_e err);
> +
>  /* When PID has exited or has been detached, we no longer want to keep
>     track of it as using libpthread.  Call this function to discard
>     thread_db related info related to PID.  Note that this closes
> @@ -273,6 +276,17 @@ delete_thread_db_info (int pid)
>    if (info == NULL)
>      return;
>  
> +  if (info->thread_agent != NULL && info->td_ta_delete_p != NULL)
> +    {
> +      td_err_e err;
> +
> +      err = info->td_ta_delete_p (info->thread_agent);

You can declare and initialize in the same line/statement.

> +      if (err != TD_OK)
> +	warning (_("Cannot deregister target process: %s"),
> +		 thread_db_err_str (err));

Should mention libthread_db here, otherwise I think this
warning may appear mystifying.  Maybe mention the PID as well,
in case we're debugging more than one process?  Like:

	warning (_("Cannot deregister process %d from libthread_db: %s"),
		 pid, thread_db_err_str (err));

Otherwise looks fine.  Please push.  Thanks!

Pedro Alves