From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 37022 invoked by alias); 27 Apr 2017 08:55:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 35978 invoked by uid 89); 27 Apr 2017 08:55:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LOTSOFHASH,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Supply, Went X-HELO: EUR03-AM5-obe.outbound.protection.outlook.com Received: from mail-eopbgr30080.outbound.protection.outlook.com (HELO EUR03-AM5-obe.outbound.protection.outlook.com) (40.107.3.80) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 27 Apr 2017 08:55:53 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com (10.160.211.19) by AM3PR08MB0102.eurprd08.prod.outlook.com (10.160.211.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1061.12; Thu, 27 Apr 2017 08:55:52 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::c065:778f:9924:8660]) by AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::c065:778f:9924:8660%14]) with mapi id 15.01.1047.019; Thu, 27 Apr 2017 08:55:52 +0000 From: Alan Hayward To: Yao Qi CC: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH 8/11] Add FRV_MAX_REGISTER_SIZE Date: Thu, 27 Apr 2017 08:55:00 -0000 Message-ID: <22BD364F-A9A9-4E21-BC47-96A320760640@arm.com> References: <3B3BD949-1C9D-44FF-AB6A-03091ECA49D0@arm.com> <867f2rw9br.fsf@gmail.com> In-Reply-To: authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=arm.com; x-microsoft-exchange-diagnostics: 1;AM3PR08MB0102;7:ebhhfebJ86yGgdw/2R8+If992Q3Ls+umAP5pCey8nPLJbc6Pq/fo1h7wd8l7BH54L0fHev0Y5a2fQL8EN5CTHHvYZXQSfWklJ/KLnG5VL06NzpmECX5SQWEIOpuZ5sho40k29L4Cq08PxmGzilfouGOfolkfbWNsGENClniSxXyWsrIWfL4pJBzw3/AAw/ArUz7iJgCS1TUIEVIclQKXVR56+XH1cIaKNFREixubkpcUaK5BGaeBex/O0Mqka5Gk+1mFPt0Ug4eQeQn9Y/akAzXHHegZguegZEqGrB7hRCJpQJZq9FjuqQy04JPP0YnhS4DPgalLeuUpycw4/LzDnQ== x-ms-office365-filtering-correlation-id: 040e5752-bf32-464c-6973-08d48d4b3580 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081);SRVR:AM3PR08MB0102; nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041248)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123560025)(20161123562025)(20161123555025)(6072148);SRVR:AM3PR08MB0102;BCL:0;PCL:0;RULEID:;SRVR:AM3PR08MB0102; x-forefront-prvs: 029097202E x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(39400400002)(39410400002)(39450400003)(39850400002)(39840400002)(39860400002)(377424004)(24454002)(305945005)(39060400002)(25786009)(38730400002)(110136004)(229853002)(3660700001)(53546009)(6916009)(6486002)(3280700002)(6506006)(1411001)(7736002)(2950100002)(76176999)(189998001)(6246003)(66066001)(2906002)(8676002)(53936002)(2900100001)(8936002)(50986999)(54356999)(4326008)(6436002)(81166006)(33656002)(54906002)(575784001)(36756003)(86362001)(5250100002)(99286003)(5660300001)(6116002)(83716003)(102836003)(6512007)(82746002)(3846002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM3PR08MB0102;H:AM3PR08MB0101.eurprd08.prod.outlook.com;FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <1E644D87DA1C494BB31EC456C48DC3B5@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2017 08:55:52.3822 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR08MB0102 X-SW-Source: 2017-04/txt/msg00726.txt.bz2 DQo+IE9uIDEyIEFwciAyMDE3LCBhdCAwOToyNywgQWxhbiBIYXl3YXJkIDxB bGFuLkhheXdhcmRAYXJtLmNvbT4gd3JvdGU6DQo+IA0KPiANCj4+IE9uIDEx IEFwciAyMDE3LCBhdCAxMTowMiwgWWFvIFFpIDxxaXlhb2x0Y0BnbWFpbC5j b20+IHdyb3RlOg0KPj4gDQo+PiBBbGFuIEhheXdhcmQgPEFsYW4uSGF5d2Fy ZEBhcm0uY29tPiB3cml0ZXM6DQo+PiANCj4+PiAtICBjaGFyIHplcm9idWZb TUFYX1JFR0lTVEVSX1NJWkVdOw0KPj4+ICsgIGNoYXIgemVyb2J1ZltGUlZf TUFYX1JFR0lTVEVSX1NJWkVdOw0KPj4+IA0KPj4+IC0gIG1lbXNldCAoemVy b2J1ZiwgMCwgTUFYX1JFR0lTVEVSX1NJWkUpOw0KPj4+ICsgIG1lbXNldCAo emVyb2J1ZiwgMCwgRlJWX01BWF9SRUdJU1RFUl9TSVpFKTsNCj4+PiANCj4+ PiAgLyogZ3IwIGFsd2F5cyBjb250YWlucyAwLiAgQWxzbywgdGhlIGtlcm5l bCBwYXNzZXMgdGhlIFRCUiB2YWx1ZSBpbg0KPj4+ICAgICB0aGlzIHNsb3Qu ICAqLw0KPj4gDQo+PiBUaGUgY29kZSBoZXJlIGZpbGxzIHNvbWUgZ3IgcmVn aXN0ZXJzIHdpdGggemVyb3MsDQo+PiANCj4+IC8qIGdyMCBhbHdheXMgY29u dGFpbnMgMC4gIEFsc28sIHRoZSBrZXJuZWwgcGFzc2VzIHRoZSBUQlIgdmFs dWUgaW4NCj4+ICAgIHRoaXMgc2xvdC4gICovDQo+PiByZWdjYWNoZV9yYXdf c3VwcGx5IChyZWdjYWNoZSwgZmlyc3RfZ3ByX3JlZ251bSwgemVyb2J1Zik7 DQo+PiANCj4+IC8qIEZpbGwgZ3IzMiwgLi4uLCBncjYzIHdpdGggemVyb3Mu ICovDQo+PiBmb3IgKHJlZ2kgPSBmaXJzdF9ncHJfcmVnbnVtICsgMzI7IHJl Z2kgPD0gbGFzdF9ncHJfcmVnbnVtOyByZWdpKyspDQo+PiAgIHJlZ2NhY2hl X3Jhd19zdXBwbHkgKHJlZ2NhY2hlLCByZWdpLCB6ZXJvYnVmKTsNCj4+IA0K Pj4gdGhlIHNpemUgb2YgdGhlc2UgZ3IgcmVnaXN0ZXJzIGFyZSBrbm93LCA4 IGJ5dGVzLiAgSXQgd29uJ3QgYmUgY2hhbmdlZC4NCj4+IFdlIGNhbiBkbywN Cj4+IA0KPj4gZ2RiX2J5dGUgemVyb2J1Zls4XSA9IHsgMCB9Ow0KPj4gDQo+ PiB0aGUgY29kZSBpcyBzdGlsbCBlYXN5IHRvIHJlYWQuICBJZiB5b3UgcmVh bGx5IGRpc2xpa2UgbWFnaWMgbnVtYmVyIChJTU8sIDgNCj4+IGlzIG5vdCBh IG1hZ2ljIG51bWJlciBpbiB0aGlzIGNvbnRleHQpLCB5b3UgY2FuIGRlZmlu ZSBGUlJfR1JfUkVHSVNURVJfU0laRS4NCj4+IA0KPj4gQWx0ZXJuYXRpdmVs eSwgeW91IGNhbiBhZGQgYSBuZXcgcmVnYWNoZSBhcGksIHJlZ2NhY2hlX3Jh d19zdXBwbHlfemVyby4NCj4+IE1hbnkgcGxhY2VzIGNhbiB1c2UgdGhpcyBh cGksIGFuZCBzb21lIHVzZXMgb2YgTUFYX1JFR0lTVEVSX1NJWkUgY2FuIGJl DQo+PiByZW1vdmVkIHRvbywgZm9yIGV4YW1wbGUsDQo+PiANCj4+IHJlZ2Nh Y2hlX3Jhd19zdXBwbHkgKHJlZ2NhY2hlLCBNSVBTX1pFUk9fUkVHTlVNLCB6 ZXJvYnVmKTsNCj4+IA0KPj4gLS0gDQo+PiBZYW8gKOm9kOWwpykNCj4gDQo+ IFdlbnQgd2l0aCB0aGUgc2ltcGxlciBzb2x1dGlvbi4NCj4gDQo+IEkgZG9u J3QgaGF2ZSBhIEZSViBtYWNoaW5lIHRvIHRlc3Qgb24uDQo+IFRlc3RlZCBv biBhIC0tZW5hYmxlLXRhcmdldHM9YWxsIGJ1aWxkIHVzaW5nIG1ha2UgY2hl Y2sgd2l0aCBib2FyZCBmaWxlcw0KPiB1bml4IGFuZCBuYXRpdmUtZ2Ric2Vy dmVyLg0KPiANCg0KTG9va2luZyBhZ2FpbiBhdCBteSBsYXRlciBwYXRjaGVz LCBJIGFncmVlIHRoYXQgcmVnY2FjaGVfcmF3X3N1cHBseV96ZXJvDQp3b3Vs ZCBiZSB1c2VmdWwgaW4gb3RoZXIgcGxhY2VzIHRvby4NCg0KSSBjb25zaWRl cmVkIG1ha2luZyByZWdjYWNoZV9yYXdfc3VwcGx5X3plcm8gY2FsbCByZWdj YWNoZV9yYXdfc3VwcGx5LCBidXQNCmluIHRoZSBlbmQgaXQgbWFkZSBtb3Jl IHNlbnNlIHRvIG1ha2UgaXQgY29tcGxldGVseSBzZXBhcmF0ZS4NCg0KSSBk b24ndCBoYXZlIGEgRlJWIG1hY2hpbmUgdG8gdGVzdCBvbi4NClRlc3RlZCBv biBhIC0tZW5hYmxlLXRhcmdldHM9YWxsIGJ1aWxkIHVzaW5nIG1ha2UgY2hl Y2sgd2l0aCBib2FyZCBmaWxlcw0KdW5peCBhbmQgbmF0aXZlLWdkYnNlcnZl ci4NCg0KT2sgdG8gY29tbWl0Pw0KDQpBbGFuLg0KDQoyMDE3LTA0LTI3ICBB bGFuIEhheXdhcmQgIDxhbGFuLmhheXdhcmRAYXJtLmNvbT4NCg0KCSogZ2Ri L2Zydi1saW51eC10ZGVwLmMgKGZydl9saW51eF9zdXBwbHlfZ3JlZ3NldCk6 IENhbGwNCglyZWdjYWNoZV9yYXdfc3VwcGx5X3plcm8NCgkqIGdkYi9yZWdj YWNoZS5jIChyZWdjYWNoZV9yYXdfc3VwcGx5X3plcm8pOiBOZXcuDQoJKiBn ZGIvcmVnY2FjaGUuaCAocmVnY2FjaGVfcmF3X3N1cHBseV96ZXJvKTogTmV3 IGRlY2xhcmF0aW9uLg0KDQoNCmRpZmYgLS1naXQgYS9nZGIvZnJ2LWxpbnV4 LXRkZXAuYyBiL2dkYi9mcnYtbGludXgtdGRlcC5jDQppbmRleCBlYjg3Zjkz MDU4YjAyODdlOGYwNWM1ODVkMWI2YWExZmYyYmZmYjc4Li5kNTJlYjIxNjM0 MzdlMzIwMjljOTg5YzJjYWVjY2U4NTMzZjExYTY1IDEwMDY0NA0KLS0tIGEv Z2RiL2Zydi1saW51eC10ZGVwLmMNCisrKyBiL2dkYi9mcnYtbGludXgtdGRl cC5jDQpAQCAtNDEzLDE3ICs0MTMsMTQgQEAgZnJ2X2xpbnV4X3N1cHBseV9n cmVnc2V0IChjb25zdCBzdHJ1Y3QgcmVnc2V0ICpyZWdzZXQsDQogCQkJICBp bnQgcmVnbnVtLCBjb25zdCB2b2lkICpncmVncywgc2l6ZV90IGxlbikNCiB7 DQogICBpbnQgcmVnaTsNCi0gIGNoYXIgemVyb2J1ZltNQVhfUkVHSVNURVJf U0laRV07DQotDQotICBtZW1zZXQgKHplcm9idWYsIDAsIE1BWF9SRUdJU1RF Ul9TSVpFKTsNCg0KICAgLyogZ3IwIGFsd2F5cyBjb250YWlucyAwLiAgQWxz bywgdGhlIGtlcm5lbCBwYXNzZXMgdGhlIFRCUiB2YWx1ZSBpbg0KICAgICAg dGhpcyBzbG90LiAgKi8NCi0gIHJlZ2NhY2hlX3Jhd19zdXBwbHkgKHJlZ2Nh Y2hlLCBmaXJzdF9ncHJfcmVnbnVtLCB6ZXJvYnVmKTsNCisgIHJlZ2NhY2hl X3Jhd19zdXBwbHlfemVybyAocmVnY2FjaGUsIGZpcnN0X2dwcl9yZWdudW0p Ow0KDQogICAvKiBGaWxsIGdyMzIsIC4uLiwgZ3I2MyB3aXRoIHplcm9zLiAq Lw0KICAgZm9yIChyZWdpID0gZmlyc3RfZ3ByX3JlZ251bSArIDMyOyByZWdp IDw9IGxhc3RfZ3ByX3JlZ251bTsgcmVnaSsrKQ0KLSAgICByZWdjYWNoZV9y YXdfc3VwcGx5IChyZWdjYWNoZSwgcmVnaSwgemVyb2J1Zik7DQorICAgIHJl Z2NhY2hlX3Jhd19zdXBwbHlfemVybyAocmVnY2FjaGUsIHJlZ2kpOw0KDQog ICByZWdjYWNoZV9zdXBwbHlfcmVnc2V0IChyZWdzZXQsIHJlZ2NhY2hlLCBy ZWdudW0sIGdyZWdzLCBsZW4pOw0KIH0NCmRpZmYgLS1naXQgYS9nZGIvcmVn Y2FjaGUuaCBiL2dkYi9yZWdjYWNoZS5oDQppbmRleCBmMjAxZjBjMDg0ZjQw Y2NmMjc2YTdlMWJhMTkwNTBjYmMxMTIwOGFkLi5mZjZlNTgzYTQ4ZjkyMDBm NGE0NmVhNWZjY2E2OWJmZGQyODYyZGFjIDEwMDY0NA0KLS0tIGEvZ2RiL3Jl Z2NhY2hlLmgNCisrKyBiL2dkYi9yZWdjYWNoZS5oDQpAQCAtMTUyLDYgKzE1 MiwxMiBAQCBleHRlcm4gdm9pZCByZWdjYWNoZV9yYXdfc3VwcGx5IChzdHJ1 Y3QgcmVnY2FjaGUgKnJlZ2NhY2hlLA0KIGV4dGVybiB2b2lkIHJlZ2NhY2hl X3Jhd19jb2xsZWN0IChjb25zdCBzdHJ1Y3QgcmVnY2FjaGUgKnJlZ2NhY2hl LA0KIAkJCQkgIGludCByZWdudW0sIHZvaWQgKmJ1Zik7DQoNCisvKiBTdXBw bHkgcmVnaXN0ZXIgUkVHTlVNIHdpdGggemVyb2VkIHZhbHVlIHRvIFJFR0NB Q0hFLiAgVGhpcyBpcyBub3QgdGhlIHNhbWUNCisgICBhcyBjYWxsaW5nIHJl Z2NhY2hlX3Jhd19zdXBwbHkgd2l0aCBOVUxMICh3aGljaCB3aWxsIHNldCB0 aGUgc3RhdGUgdG8NCisgICB1bmF2YWlsYWJsZSkuICAqLw0KKw0KK2V4dGVy biB2b2lkIHJlZ2NhY2hlX3Jhd19zdXBwbHlfemVybyAoc3RydWN0IHJlZ2Nh Y2hlICpyZWdjYWNoZSwgaW50IHJlZ251bSk7DQorDQogLyogQ29sbGVjdCBy ZWdpc3RlciBSRUdOVU0gZnJvbSBTT1VSQ0VfUkVHQ0FDSEUgYW5kIHN0b3Jl IGl0cyBjb250ZW50cyB0bw0KICAgIERFU1RfUkVHQ0FDSEUuICAqLw0KIGV4 dGVybiB2b2lkIHJlZ2NhY2hlX3Jhd19jb3B5IChjb25zdCBzdHJ1Y3QgcmVn Y2FjaGUgKmRlc3RfcmVnY2FjaGUsDQpkaWZmIC0tZ2l0IGEvZ2RiL3JlZ2Nh Y2hlLmMgYi9nZGIvcmVnY2FjaGUuYw0KaW5kZXggMjBlNDNmNDg2ZmYwMmYx NTAwMGJlYmVlMmE0ZWIwM2RiNTMxMTFkNC4uMDNmN2QyMTZmN2QyZmI4ZGQy ZTViMTE4OWM5NzQzZWQzN2ZhY2IzMCAxMDA2NDQNCi0tLSBhL2dkYi9yZWdj YWNoZS5jDQorKysgYi9nZGIvcmVnY2FjaGUuYw0KQEAgLTExMjUsNiArMTEy NSwyNyBAQCByZWdjYWNoZV9yYXdfY29sbGVjdCAoY29uc3Qgc3RydWN0IHJl Z2NhY2hlICpyZWdjYWNoZSwgaW50IHJlZ251bSwgdm9pZCAqYnVmKQ0KICAg bWVtY3B5IChidWYsIHJlZ2J1Ziwgc2l6ZSk7DQogfQ0KDQorLyogU3VwcGx5 IHJlZ2lzdGVyIFJFR05VTSB3aXRoIHplcm9lZCB2YWx1ZSB0byBSRUdDQUNI RS4gIFRoaXMgaXMgbm90IHRoZSBzYW1lDQorICAgYXMgY2FsbGluZyByZWdj YWNoZV9yYXdfc3VwcGx5IHdpdGggTlVMTCAod2hpY2ggd2lsbCBzZXQgdGhl IHN0YXRlIHRvDQorICAgdW5hdmFpbGFibGUpLiAgKi8NCisNCit2b2lkDQor cmVnY2FjaGVfcmF3X3N1cHBseV96ZXJvIChzdHJ1Y3QgcmVnY2FjaGUgKnJl Z2NhY2hlLCBpbnQgcmVnbnVtKQ0KK3sNCisgIHZvaWQgKnJlZ2J1ZjsNCisg IHNpemVfdCBzaXplOw0KKw0KKyAgZ2RiX2Fzc2VydCAocmVnY2FjaGUgIT0g TlVMTCk7DQorICBnZGJfYXNzZXJ0IChyZWdudW0gPj0gMCAmJiByZWdudW0g PCByZWdjYWNoZS0+ZGVzY3ItPm5yX3Jhd19yZWdpc3RlcnMpOw0KKyAgZ2Ri X2Fzc2VydCAoIXJlZ2NhY2hlLT5yZWFkb25seV9wKTsNCisNCisgIHJlZ2J1 ZiA9IHJlZ2lzdGVyX2J1ZmZlciAocmVnY2FjaGUsIHJlZ251bSk7DQorICBz aXplID0gcmVnY2FjaGUtPmRlc2NyLT5zaXplb2ZfcmVnaXN0ZXJbcmVnbnVt XTsNCisNCisgIG1lbXNldCAocmVnYnVmLCAwLCBzaXplKTsNCisgIHJlZ2Nh Y2hlLT5yZWdpc3Rlcl9zdGF0dXNbcmVnbnVtXSA9IFJFR19WQUxJRDsNCit9 DQorDQogdm9pZA0KIHJlZ2NhY2hlX3Jhd19jb3B5IChjb25zdCBzdHJ1Y3Qg cmVnY2FjaGUgKmRlc3RfcmVnY2FjaGUsIGludCByZWdudW0sDQogCQkgICBz dHJ1Y3QgcmVnY2FjaGUgKnNyY19yZWdjYWNoZSkNCg0KDQoNCg== >From gdb-patches-return-138643-listarch-gdb-patches=sources.redhat.com@sourceware.org Thu Apr 27 08:58:49 2017 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 9176 invoked by alias); 27 Apr 2017 08:58:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 9159 invoked by uid 89); 27 Apr 2017 08:58:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=late X-HELO: mail-wr0-f182.google.com Received: from mail-wr0-f182.google.com (HELO mail-wr0-f182.google.com) (209.85.128.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 27 Apr 2017 08:58:45 +0000 Received: by mail-wr0-f182.google.com with SMTP id l50so13121883wrc.3 for ; Thu, 27 Apr 2017 01:58:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=eTb3bB/Uji+yEWGCUbK7rTuvTkCxxC81X2L6OSWneXw=; b=L0An10w/3RqoZkLzCIqlRoZTu1umTGFpCt7qT0Jthh3nR0NBXjhT39fy3V3T7uXV83 fldHVc2DQb/mstKalWf+xD+/9kkmTx3hb4geg6WugAXN+1zXyiNketamsJXYYqZ9U+P2 yT7Xmiaq4haXvhxMcHMyGGTTweWX9JxDREQxTuyldNxueALKV+jm1J54HVDEgyItKXam CsuloLDi0OxSzl8l3GkHsC2p1LQQedGOGjWq9ZzYKxxiHjrNYhcxzRUrnqhU7yzeh7Dl SgAtPUGuahkpNd2tHRjDC9CJygtkrdJveUbhbjeb6wSTnhmDNtKUBZ0hTTri5RACCUdh v9zw== X-Gm-Message-State: AN3rC/5u3/hwihNhjfxpaUaqaqhUgRG8Z27IIN7kFH154TIdCm7mx0Fs APmC+nkI4rHObl86GkR3dw== X-Received: by 10.223.171.26 with SMTP id q26mr2686624wrc.15.1493283525479; Thu, 27 Apr 2017 01:58:45 -0700 (PDT) Received: from ?IPv6:2a02:c7f:ae15:7800:4685:ff:fe66:9f4? ([2a02:c7f:ae15:7800:4685:ff:fe66:9f4]) by smtp.gmail.com with ESMTPSA id s27sm1216238wra.25.2017.04.27.01.58.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Apr 2017 01:58:44 -0700 (PDT) Subject: Re: [RFA 00/10] various frame filter fixes and cleanups To: Tom Tromey , gdb-patches@sourceware.org References: <20170425194113.17862-1-tom@tromey.com> From: Phil Muldoon Message-ID: Date: Thu, 27 Apr 2017 08:58:00 -0000 MIME-Version: 1.0 In-Reply-To: <20170425194113.17862-1-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00727.txt.bz2 Content-length: 1128 On 25/04/17 20:41, Tom Tromey wrote: > This series fixes a few frame filter bugs. Some of them have been > reported, but some not. > > There are some documentation changes in patch #1 and patch #3. > > For the most part I think each patch is reasonably self-explanatory. > However, there are a couple of things to note here: > > * You might wonder about the choice of constant in patch #3. I chose > 32 rather than 16 so as not to conflict with my earlier frame-filter > patch, in review. > > * In some cases writing a test seemed pretty difficult, and also maybe > low-impact, so I didn't. This applies to patch #6, #9, and #10. > > A future direction for patch #3 would be to add a new "set" command so > that a user can choose "bt elide" as the default. > > Tested on the buildbot. I've looked through the patches and nothing stands out (beyond the minor nits pointed out already). I'd like to make the case that this be an inclusion for GDB 8. It's a series of very nice bugfixes for some long standing issues. It might be too late in the day for this, though. What does everyone else think? Cheers Phil