From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 74515 invoked by alias); 13 Jun 2019 13:29:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 74507 invoked by uid 89); 13 Jun 2019 13:29:42 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1000 X-HELO: mail-wr1-f68.google.com Received: from mail-wr1-f68.google.com (HELO mail-wr1-f68.google.com) (209.85.221.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Jun 2019 13:29:37 +0000 Received: by mail-wr1-f68.google.com with SMTP id p13so10700990wru.10 for ; Thu, 13 Jun 2019 06:29:36 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:4eeb:42ff:feef:f164? ([2001:8a0:f913:f700:4eeb:42ff:feef:f164]) by smtp.gmail.com with ESMTPSA id g19sm3479769wmg.10.2019.06.13.06.29.33 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Thu, 13 Jun 2019 06:29:34 -0700 (PDT) Subject: Re: [PATCH] Move gnulib to top level To: Tom Tromey , gdb-patches@sourceware.org References: <20190613124818.15130-1-tom@tromey.com> From: Pedro Alves Message-ID: <229bf3df-3fe3-60e1-cfec-448810839fa5@redhat.com> Date: Thu, 13 Jun 2019 13:29:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190613124818.15130-1-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-06/txt/msg00246.txt.bz2 On 6/13/19 1:48 PM, Tom Tromey wrote: > This patch moves the gdb/gnulib subdirectory to the top level. > > It adjusts the top-level build system to build gnulib when necessary, > and changes gdb to use this. However, gdbserver still builds its own > copy of gnulib, just from the new source location. > > A small hack was needed to ensure that gnulib is only built when gdb > is enabled. The Makefile only provides an ordering -- the directory > must be mentioned in configdirs to actually be compiled at all. > > Most of the patch is just a "git mv" of gnulib, though a few minor > path adjustments were needed in some files there. > Also, gnulib/configure.ac is using ACX_LARGEFILE now. > Tested by the buildbot. > I think we'll need the following, though not necessarily in this patch: - a gnulib/README file - to list gnulib in top/MAINTAINERS LGTM. I'm sure you know, but JIC, the top-level changes will need to go to gcc too. Thanks, Pedro Alves