From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59208 invoked by alias); 22 Sep 2017 17:41:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 59190 invoked by uid 89); 22 Sep 2017 17:41:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 22 Sep 2017 17:41:53 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 013E146213 for ; Fri, 22 Sep 2017 17:41:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 013E146213 Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id E7F595D9CA; Fri, 22 Sep 2017 17:41:48 +0000 (UTC) Subject: Re: [PATCH v3 3/5] Introduce gdb_tilde_expand To: Sergio Durigan Junior References: <20170912042325.14927-1-sergiodj@redhat.com> <20170921225926.23132-1-sergiodj@redhat.com> <20170921225926.23132-4-sergiodj@redhat.com> <2045d081-c89b-e83f-97a7-d4e3397aa476@redhat.com> <87d16i4otu.fsf@redhat.com> Cc: GDB Patches From: Pedro Alves Message-ID: <2277cb1a-0aa5-6bc7-d09c-2a8258dc4db6@redhat.com> Date: Fri, 22 Sep 2017 17:41:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <87d16i4otu.fsf@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-09/txt/msg00685.txt.bz2 On 09/22/2017 06:37 PM, Sergio Durigan Junior wrote: > On Friday, September 22 2017, Pedro Alves wrote: >> I realized something: in light of the fact that "cd" is not what >> is used to specify the inferior's cwd anymore since v1, patching >> this particular use of tilde_expand, and not others seems arbitrary. >> >> I.e., this now looks like kind of a spurious change to me, and >> I think you should drop the changes to this file... > > Yeah, you're right. I still intend to keep the cleanups, if that's OK > for you. I don't know what you mean by that. > >>> +/* See common/gdb_tilde_expand.h. */ >>> + >>> +std::string >>> +gdb_tilde_expand (const char *dir) >>> +{ >>> + gdb_glob glob (dir, GLOB_TILDE | GLOB_TILDE_CHECK | GLOB_ONLYDIR, NULL); >> >> By my reading of man glob, GLOB_TILDE_CHECK already implies GLOB_TILDE. > > Yes, but I think it pays to be explicit in this case. I think it only adds to confusion. I did "man glob", saw that GLOB_TILDE_CHECK implies GLOB_TILDE and then got to wonder why is GLOB_TILDE being passed explicitly. > I'll remove GLOB_ONLYDIR and resubmit the patch. Fine with me. Thanks, Pedro Alves