From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 1r6CBRRSW2B3YAAAWB0awg (envelope-from ) for ; Wed, 24 Mar 2021 10:52:04 -0400 Received: by simark.ca (Postfix, from userid 112) id 088F51EF78; Wed, 24 Mar 2021 10:52:04 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 687CA1E789 for ; Wed, 24 Mar 2021 10:52:03 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B52443857C50; Wed, 24 Mar 2021 14:52:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B52443857C50 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1616597522; bh=4RpkcEAA0CHums0rIRosEwk5a2j2u0NtJKiStTC3lyQ=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=h+c8SuVfPqnkR1+VPtPAmrjtOqDuh47XdsOFYP7vkK/r0Tg6cqt2cLmmXhJayPDCh lcT0VVQ+/3kElPw/uiUErKWqbLEQmc0pfXO44e+OQisjIUhb4CZFBFMof07WapQeiQ kv2ecFnR7OJBlLQVRWzmI5jwt7GbHQqTPkaa8j8o= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 6B0B23857C50 for ; Wed, 24 Mar 2021 14:52:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6B0B23857C50 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-536-5s351oxiMh-RsXB6YIIpjA-1; Wed, 24 Mar 2021 10:51:58 -0400 X-MC-Unique: 5s351oxiMh-RsXB6YIIpjA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 79441190A7A5; Wed, 24 Mar 2021 14:51:57 +0000 (UTC) Received: from theo.uglyboxes.com (ovpn-113-66.phx2.redhat.com [10.3.113.66]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4BD2019C71; Wed, 24 Mar 2021 14:51:57 +0000 (UTC) Subject: Re: [PATCH 9/9] C++ compile support To: Simon Marchi , gdb-patches@sourceware.org References: <20180810232534.481-1-keiths@redhat.com> <20180810232534.481-10-keiths@redhat.com> Message-ID: <226bae37-cd78-69e6-17d8-8450690b7b73@redhat.com> Date: Wed, 24 Mar 2021 07:51:56 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Keith Seitz via Gdb-patches Reply-To: Keith Seitz Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 3/23/21 6:04 PM, Simon Marchi wrote: > Hi Keith, > > I am from the past... Hahaha... That's okay; I feel like I am living in the past! > On 2018-08-10 7:25 p.m., Keith Seitz wrote: >> + gcc_decl resuld; >> + if (TYPE_CODE (type) == TYPE_CODE_STRUCT) >> + { >> + const char *what = TYPE_DECLARED_CLASS (type) ? "struct" : "class"; > > I don't know if this matters, but the condition above looks reversed, > can you confirm? Wowser. Good catch! While it should *of course* be corrected, the first parameter there is essentially for debugging, so it is not critical that this be propagated everywhere: gcc_expr build_decl (const char *debug_decltype, const char *name, enum gcc_cp_symbol_kind sym_kind, gcc_type sym_type, const char *substitution_name, gcc_address address, const char *filename, unsigned int line_number); Let me know if you want me to clean up my boo-boo or whether you've patch-in-hand to push already. Keith