From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by sourceware.org (Postfix) with ESMTP id D20C9386F471 for ; Fri, 22 May 2020 15:47:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D20C9386F471 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-101-nk79-J9DODGJDCGoUlVEZg-1; Fri, 22 May 2020 11:47:50 -0400 X-MC-Unique: nk79-J9DODGJDCGoUlVEZg-1 Received: by mail-wm1-f72.google.com with SMTP id f62so4287684wme.3 for ; Fri, 22 May 2020 08:47:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=o+jkOoYbCk0xT3FADl90pAvfK5g8LtyvmdNUp37KjLA=; b=uLT9seLAGSWm614bOcIxcQX2TYOrg8L/FDVQUd2t+YonQoAfKAigvwSRu3XB0N+iTp Mrrr0ltE2fhIi3styYoGvK5pTKBa2LkWJ1R1CBSNmL8S8cIaSU7oN540I3QSU5DGig6t l9WvAP1FU/cVKSaLMcf5I9aAjGQBBwHyw78YVGsDUj+PSLZqhdPtOwNQqQCCOs1MDtuP YvI/JdsyiwGcZeb9JNZJrCF9vH/wjWrP9+IrCjUjZcF1N4lLa2xz8zydiUP3QLtRy2p9 Zw4Wc8Af8NNpCH6f1CsqKgg2VkmurwLwojleSXSSc4fAG6wzh0r6qHhCg6T7vnlD0nVb dRrQ== X-Gm-Message-State: AOAM530tocNAOUloGErfh1U2RAd4EBHRGMlRq3Smj1XyoOjhryimPDqg 92ITXQGk/UI1JQSIhdZEUSVXOLJ8xT/V6Bcm17TZyH6XpgmLON/VCltXIHFpaXMyG6BaiK2ocuI rmh/+XJW71nW7LQduirHsPQ== X-Received: by 2002:a5d:5047:: with SMTP id h7mr3887211wrt.7.1590162469215; Fri, 22 May 2020 08:47:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw/6AyJ9UOqPtei+5pP6PnXdjh6xFJGfbxJEMIPSTIYRdRHhLuPBsZNCZICVzV3d58lpKYGKQ== X-Received: by 2002:a5d:5047:: with SMTP id h7mr3887195wrt.7.1590162469012; Fri, 22 May 2020 08:47:49 -0700 (PDT) Received: from ?IPv6:2001:8a0:f909:7b00:56ee:75ff:fe8d:232b? ([2001:8a0:f909:7b00:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id x5sm10295934wro.12.2020.05.22.08.47.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 May 2020 08:47:48 -0700 (PDT) Subject: Re: [PATCH 1/4] Attribute method inlining To: Hannes Domani , Gdb-patches References: <20200520174032.9525-1-tromey@adacore.com> <20200520174032.9525-2-tromey@adacore.com> <402931801.2106918.1590023319120@mail.yahoo.com> <57ffa2a6-6636-d50c-a058-5244c41e0e96@redhat.com> <1561975515.2543878.1590073437956@mail.yahoo.com> <3b5b38b1-ccf2-199b-d2cd-c17e86659000@redhat.com> <527321070.2641378.1590081500100@mail.yahoo.com> From: Pedro Alves Message-ID: <226240ff-8fa8-e47a-1a3b-0b0f30d41698@redhat.com> Date: Fri, 22 May 2020 16:47:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <527321070.2641378.1590081500100@mail.yahoo.com> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 May 2020 15:47:55 -0000 On 5/21/20 6:18 PM, Hannes Domani via Gdb-patches wrote: > Am Donnerstag, 21. Mai 2020, 18:42:23 MESZ hat Pedro Alves Folgendes geschrieben: > >> On 5/21/20 4:03 PM, Hannes Domani via Gdb-patches wrote: >>>> There was a patch for this not that long ago.  Let me try to dig it up. >>> >>> You're right, I found it here: >>> https://sourceware.org/pipermail/gdb-patches/2019-June/158285.html >> >> Yes, that's the one! >> >>> >>> So I guess it's not just on Windows that slow. >>> >>> And you replied that we maybe should use TOLOWER, ISXDIGIT from libiberty >>> instead: >>> https://sourceware.org/pipermail/gdb-patches/2019-June/158518.html >> >> This message is actually older than the patch above -- I wrote the patch >> afterwards. >> >> The patch is using the libiberty macros, and avoids the readline clash >> you run into.  Could you give it a try? > > It wasn't immediately obvious to me, but I think you mean this one: > https://sourceware.org/pipermail/gdb-patches/2019-June/158525.html Oh, wow, I confused the "158525" in the url with "158285". They looked the same number to me. Sorry. Yes, I meant that patch as you found out. > > I tried it, and as expected, I get the same speedup as with my previous > test, and strcmp_iw_ordered is now in only ~1.5% of the profiling samples. Awesome. Let me write some git log / ChangeLog for it and resend it as a separate thread. Thanks, Pedro Alves