From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 63953 invoked by alias); 19 Sep 2016 15:23:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 63920 invoked by uid 89); 19 Sep 2016 15:23:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.0 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=alternatively X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 19 Sep 2016 15:23:07 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EC6897F7AA; Mon, 19 Sep 2016 15:23:05 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u8JFN4gl032711; Mon, 19 Sep 2016 11:23:05 -0400 Subject: Re: [PATCH] gdb: Use std::max and std::min throughout To: Ulrich Weigand References: <20160919145640.AFC84100083@oc8523832656.ibm.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <2234d72c-6eae-ac7b-131c-5e6f77d53558@redhat.com> Date: Mon, 19 Sep 2016 15:23:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160919145640.AFC84100083@oc8523832656.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-09/txt/msg00210.txt.bz2 On 09/19/2016 03:56 PM, Ulrich Weigand wrote: > Pedro Alves wrote: > >> I tried a --disable-nls with both gcc 5.1 and 4.7 here, and it >> doesn't trigger this. I can't seem to find the libintl.h inclusion >> you're seeing. Sounds like that was changed at some point. > > Yes, it looks like these days the C++ headers include a lot fewer > of the base C headers (fixing namespace pollution, maybe?). Yeah, I assume so. >> Alternatively, simply remove the troublesome *gettext and *textdomain >> macros, leaving only the _ and N_ ones. I can't seem to find any >> directly reference to gettext in the tree. The textdomain calls >> in main.c would need to be wrapped in #ifdef ENABLE_NLS, but >> likes like that is all. > > This would also work, and seems the cleanest solution. OK, I'm testing a patch. Thanks, Pedro Alves