From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2384 invoked by alias); 7 Mar 2006 14:25:16 -0000 Received: (qmail 2372 invoked by uid 22791); 7 Mar 2006 14:25:16 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-vbr3.xs4all.nl (HELO smtp-vbr3.xs4all.nl) (194.109.24.23) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 07 Mar 2006 14:25:14 +0000 Received: from webmail.xs4all.nl (dovemail9.xs4all.nl [194.109.26.11]) by smtp-vbr3.xs4all.nl (8.13.3/8.13.3) with ESMTP id k27EP7MI021112; Tue, 7 Mar 2006 15:25:08 +0100 (CET) (envelope-from mark.kettenis@xs4all.nl) Received: from 192.87.1.22 (SquirrelMail authenticated user sibelius) by webmail.xs4all.nl with HTTP; Tue, 7 Mar 2006 15:25:08 +0100 (CET) Message-ID: <22344.192.87.1.22.1141741508.squirrel@webmail.xs4all.nl> In-Reply-To: <200603071421.08416.paul@codesourcery.com> References: <200603061518.23469.paul@codesourcery.com> <200603061835.k26IZfgZ013961@elgar.sibelius.xs4all.nl> <200603071421.08416.paul@codesourcery.com> Date: Tue, 07 Mar 2006 16:52:00 -0000 Subject: Re: [patch] Avoid gcc specific compiler flags From: "Mark Kettenis" To: "Paul Brook" Cc: "Mark Kettenis" , gdb-patches@sourceware.org User-Agent: SquirrelMail/1.4.5 MIME-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-03/txt/msg00112.txt.bz2 > On Monday 06 March 2006 18:35, Mark Kettenis wrote: >> > From: Paul Brook >> > Date: Mon, 6 Mar 2006 15:18:23 +0000 >> > >> > The attached patch allows a dejagnu target description to override the >> > compiler flag used to disable warnings when running the gdb testsuite. >> > >> > Ok? >> >> Looks fine to me expect for a double $nowarnings in the gdb.exp bit. > > I don't understand this comment. Can you be more specific? I was talking about the following fragment: + set nowarnings [lsearch -exact $options nowarnings] + if {$nowarnings != -1} { + if [target_info exists gdb,nowarnings_flag] { + set flag "additional_flags=[target_info gdb,nowarnings_flag]" + } else { + set flag "additional_flags=-w" + } + set options [lreplace $options $nowarnings $nowarnings $flag] There's a double $nowarnings on that last line. or is that intentional? In that case I don't understand this code completely, and it needs a comment to explain it. Mark