From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1462 invoked by alias); 9 Aug 2007 21:29:16 -0000 Received: (qmail 1355 invoked by uid 22791); 9 Aug 2007 21:29:14 -0000 X-Spam-Check-By: sourceware.org Received: from b.mail.sonic.net (HELO b.mail.sonic.net) (64.142.19.5) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 09 Aug 2007 21:29:09 +0000 Received: from webmail.sonic.net (b.webmail.sonic.net [64.142.100.148]) by b.mail.sonic.net (8.13.8.Beta0-Sonic/8.13.7) with ESMTP id l79LSqLJ006063; Thu, 9 Aug 2007 14:28:52 -0700 Received: from 12.7.175.2 (SquirrelMail authenticated user msnyder) by webmail.sonic.net with HTTP; Thu, 9 Aug 2007 14:28:52 -0700 (PDT) Message-ID: <22328.12.7.175.2.1186694932.squirrel@webmail.sonic.net> In-Reply-To: <18107.33597.966320.942025@kahikatea.snap.net.nz> References: <17268.12.7.175.2.1186611933.squirrel@webmail.sonic.net> <18106.20613.121153.810889@kahikatea.snap.net.nz> <20070809145727.GA27809@caradoc.them.org> <18107.33597.966320.942025@kahikatea.snap.net.nz> Date: Thu, 09 Aug 2007 21:29:00 -0000 Subject: Re: [PATCH] dead code in mi-interp From: msnyder@sonic.net To: "Nick Roberts" Cc: "Daniel Jacobowitz" , msnyder@sonic.net, gdb-patches@sourceware.org User-Agent: SquirrelMail/1.4.9a MIME-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00184.txt.bz2 > > That's not what "no side effects" means - the code literally can't > > ever have an effect. It creates a string which nothing uses. Why > > keep it? > > OK, I hadn't realised that. Unless the original author (Andrew Cagney?) > explains why it's not needed I would still prefer that it wasn't removed. > It > may be that it just wasn't hooked up because the asynchronous stuff was > never > completed. Once GDB can work asynchronously then it could be removed, if > not > needed. Presumably "no side effects" also means "can do no harm". Well, it can always be recovered from the CVS repository if it is needed. Personally I'd rathern not have dead code in there just because it doesn't do any harm (unles it also has some benefit).