From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-143893-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 9382 invoked by alias); 29 Nov 2017 12:06:36 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 9372 invoked by uid 89); 29 Nov 2017 12:06:36 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 Nov 2017 12:06:35 +0000
Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id 7EE9CC058EB0;	Wed, 29 Nov 2017 12:06:34 +0000 (UTC)
Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4])	by smtp.corp.redhat.com (Postfix) with ESMTP id DB4CC600D5;	Wed, 29 Nov 2017 12:06:33 +0000 (UTC)
Subject: Re: [PATCH, gdb/testsuite] Fix wrong return type in tests
To: Thomas Preudhomme <thomas.preudhomme@foss.arm.com>, GDB Patches <gdb-patches@sourceware.org>
References: <e998867a-08b5-cbf2-004b-b9ce3d73c588@foss.arm.com> <964a7f20-21f0-3e7f-a46a-6ef34cef046c@redhat.com> <0bde66e5-b4fe-7d63-66d7-4882855b03aa@foss.arm.com>
From: Pedro Alves <palves@redhat.com>
Message-ID: <222801b2-deb4-3855-af56-7417d134c547@redhat.com>
Date: Wed, 29 Nov 2017 12:06:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <0bde66e5-b4fe-7d63-66d7-4882855b03aa@foss.arm.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2017-11/txt/msg00765.txt.bz2

On 11/29/2017 11:59 AM, Thomas Preudhomme wrote:
> My apologize, I thought it couldn't be significant since it was not
> returning anything.  I didn't think about the impact on the prototype
> itself. 

No worries.  It was easy to miss.

How about making it return 0 instead then?

Yes please, go ahead and push such a fix in.

Thanks,
Pedro Alves