From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 81678 invoked by alias); 3 May 2017 23:52:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 81665 invoked by uid 89); 3 May 2017 23:52:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=Wednesday, wednesday X-HELO: mail.baldwin.cx Received: from bigwig.baldwin.cx (HELO mail.baldwin.cx) (96.47.65.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 03 May 2017 23:52:32 +0000 Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by mail.baldwin.cx (Postfix) with ESMTPSA id 541E710A7DB; Wed, 3 May 2017 19:52:33 -0400 (EDT) From: John Baldwin To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: Re: [RFA 04/23] Use gdb_file_up in fbsd-nat.c Date: Wed, 03 May 2017 23:52:00 -0000 Message-ID: <2226527.kJJp7PXS1T@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.0-STABLE; KDE/4.14.10; amd64; ; ) In-Reply-To: <20170503224626.2818-5-tom@tromey.com> References: <20170503224626.2818-1-tom@tromey.com> <20170503224626.2818-5-tom@tromey.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00097.txt.bz2 On Wednesday, May 03, 2017 04:46:07 PM Tom Tromey wrote: > This updates fbsd-nat.c to use gdb_file_up. This removes a use of a > cleanup, and helps remove make_cleanup_fclose in a later patch. > > I have no way to test this patch. This looks fine to me. On the other hand, it's also not used on most modern versions of FreeBSD (so I don't have a good way to test it either). The new interface using sysctl has been available since FreeBSD 7.1 (released in January of 2009). -- John Baldwin