From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 108679 invoked by alias); 20 May 2016 14:30:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 108656 invoked by uid 89); 20 May 2016 14:30:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:744, subtly, decent X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 20 May 2016 14:30:36 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8C9438F4E3; Fri, 20 May 2016 14:30:35 +0000 (UTC) Received: from [10.36.112.34] (ovpn-112-34.ams2.redhat.com [10.36.112.34]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u4KEUY4a032274; Fri, 20 May 2016 10:30:34 -0400 Subject: Re: [RFA 2/3] use user_breakpoint_p in python code To: Tom Tromey , gdb-patches@sourceware.org References: <1463695563-4130-1-git-send-email-tom@tromey.com> <1463695563-4130-3-git-send-email-tom@tromey.com> From: Phil Muldoon Message-ID: <22002ad5-bde8-c832-7640-16b15d8def23@redhat.com> Date: Fri, 20 May 2016 14:30:00 -0000 MIME-Version: 1.0 In-Reply-To: <1463695563-4130-3-git-send-email-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-05/txt/msg00357.txt.bz2 On 19/05/16 23:06, Tom Tromey wrote: > I noticed that bppy_get_visibility and gdbpy_breakpoint_created > implemented their own visibility checks, but subtly different from > user_breakpoint_p. I think the latter is more correct, and so changed > the Python code to use it. > > I suspect there isn't a decent way to test this, so no new test. > > Built and regtested on x86-64 Fedora 23. > > 2016-05-19 Tom Tromey > > * python/py-breakpoint.c (bppy_get_visibility) > (gdbpy_breakpoint_created): Use user_breakpoint_p. > --- > gdb/ChangeLog | 5 +++++ > gdb/python/py-breakpoint.c | 8 ++++---- > 2 files changed, 9 insertions(+), 4 deletions(-) Looks good to me! Cheers Phil