From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 2EFBA387700C for ; Wed, 11 Mar 2020 13:27:53 +0000 (GMT) Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 0B1EC1E481; Wed, 11 Mar 2020 09:27:51 -0400 (EDT) Subject: Re: [PATCHv2 0/2] Line table is_stmt support To: Andrew Burgess Cc: Bernd Edlinger , "gdb-patches@sourceware.org" References: <20200310230132.GF3317@embecosm.com> <20200311112833.GH3317@embecosm.com> From: Simon Marchi Message-ID: <21d3ef73-ca01-0e5f-c651-6fb650464129@simark.ca> Date: Wed, 11 Mar 2020 09:27:50 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200311112833.GH3317@embecosm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US-large Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, SPF_HELO_PASS, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Mar 2020 13:27:53 -0000 On 2020-03-11 7:28 a.m., Andrew Burgess wrote: > * Simon Marchi [2020-03-11 02:50:07 -0400]: > >> On 2020-03-10 7:01 p.m., Andrew Burgess wrote: >>> * Bernd Edlinger [2020-03-08 14:39:44 +0000]: >>> >>>> On 3/8/20 1:50 PM, Andrew Burgess wrote: >>>>> Patch #1 is unchanged. >>>>> >>>>> Patch #2 includes additional changes in infrun.c based on Bernd's >>>>> suggested fix, as well as his additional tests. >>>>> >>>>> Bernd, >>>>> >>>>> If you are happy with this version of the patch that I'll merge this >>>>> in the next few days. >>>>> >>>> >>>> Sure, a quick smoke test shows this is still on the right track. >>>> >>>> I will post a re-based version of my follow-up patch in a moment. >>> >>> I have now pushed this series to master. I will review your follow up >>> patch in more detail tomorrow. >>> >>> Thanks, >>> Andrew >> >> Hi Andrew, >> >> It appears that this series (patch 2/2) causes an ASan failure, see below. >> Compiling a C file with an empty main, with debug info, and loading it in GDB is >> sufficient to trigger it. > > Apologies. > > I pushed the patch below to fix this issue. > > Thanks, > Andrew Thanks! Simon