Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: law@redhat.com
To: gdb-patches@sources.redhat.com
Subject: infttrace vs add_thread
Date: Wed, 19 Dec 2001 10:40:00 -0000	[thread overview]
Message-ID: <21994.1008787094@porcupine.cygnus.com> (raw)


When add_thread was changed to accept a ptid_t type instead of just an
integer, nobody updated infttrace.c to reflect those changes.

The net result is a segfault if you try to use GDB on hpux11.

Again, since I'm no longer a GDB maintainer, I'll hold off installing the
fix until approved by a GDB maintainer.


	* infttrate.c (child_acknowledge_created_inferior): Pass
	correct argument to add_thread.
	(update_thread_state_after_attach): Likewise.
Index: infttrace.c
===================================================================
RCS file: /cvs/cvsfiles/devo/gdb/infttrace.c,v
retrieving revision 2.22
diff -c -3 -p -r2.22 infttrace.c
*** infttrace.c	2001/09/30 19:16:20	2.22
--- infttrace.c	2001/12/18 17:50:01
*************** child_acknowledge_created_inferior (int 
*** 3123,3129 ****
     *    the process safely to ask what it is.  Anyway, we'll
     *    add it when it gets the EXEC event.
     */
!   add_thread (pid);		/* in thread.c */
  
    /* We can now set the child's ttrace event mask.
     */
--- 3123,3129 ----
     *    the process safely to ask what it is.  Anyway, we'll
     *    add it when it gets the EXEC event.
     */
!   add_thread (pid_to_ptid (pid));		/* in thread.c */
  
    /* We can now set the child's ttrace event mask.
     */
*************** update_thread_state_after_attach (int pi
*** 4764,4770 ****
  	    }
  	}
  
!       add_thread (tid);		/* in thread.c */
      }
  
  #ifdef PARANOIA
--- 4764,4770 ----
  	    }
  	}
  
!       add_thread (pid_to_ptid (pid));		/* in thread.c */
      }
  
  #ifdef PARANOIA









             reply	other threads:[~2001-12-19 18:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-12-19 10:40 law [this message]
2001-12-19 10:49 ` Andrew Cagney
2001-12-19 11:18   ` law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21994.1008787094@porcupine.cygnus.com \
    --to=law@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox