From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28232 invoked by alias); 22 Apr 2015 05:23:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13463 invoked by uid 89); 22 Apr 2015 05:22:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-pd0-f202.google.com Received: from mail-pd0-f202.google.com (HELO mail-pd0-f202.google.com) (209.85.192.202) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 22 Apr 2015 05:21:38 +0000 Received: by pdjg10 with SMTP id g10so16764178pdj.0 for ; Tue, 21 Apr 2015 22:21:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:cc:subject:in-reply-to :references; bh=6qkz9gins1xqVS0LOpkifsTxOKDgrhlJkYGDrT+5iFU=; b=D2wkgyQ/Cgv6+8QY0PRUdGealxGMh/oPrbh5qL6JKyq/WtgI5IOU/87eJGku8Gp0j/ amAowr2GEWArBlc+7geyOfVODWHIcIuLFsSldSC6DicS2kmN71L/CWS4Ie8DTwn7Ia7l QK5VUVMhUcOGNfMiomAMYH/xyFGXbEZ2vXdrZT8yby/SR5L33KDk2B68P6/28UgYcjZW guXb6p9Z9NUaZjZAY4GSl8DI5hNV7IL56loiUa44BqdO/ZG5sDfD7f8jzMPWrRcZ8TD+ xvIIOFlT+LP9f9PPVF8LzrLvIkpBqGfmQXZsj2bJxUexdA9yFpevrWAyJzHcGLx1WMfp HviQ== X-Gm-Message-State: ALoCoQl00R3BtMS3uAjE/Sd+eawKhZ4RsSTzFmyLmu0lsli4/KPM/Llf5h6eeNNSlcYyHAvN2W2dhVSnukpSzdbXEUBedo8UECv1n+IqI+X+IivEOavZty9SI8hjid6gdHk7JYhxDi/8XgaPHa5QzhLm28sNaSG94kXxaLB7X4DLFyDMZK/GDd4= X-Received: by 10.69.27.71 with SMTP id je7mr34269550pbd.2.1429680096845; Tue, 21 Apr 2015 22:21:36 -0700 (PDT) Received: from corpmail-nozzle1-2.hot.corp.google.com ([100.108.1.103]) by gmr-mx.google.com with ESMTPS id l36si357818yhb.1.2015.04.21.22.21.36 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Apr 2015 22:21:36 -0700 (PDT) Received: from ruffy2.mtv.corp.google.com ([172.17.128.107]) by corpmail-nozzle1-2.hot.corp.google.com with ESMTP id 5ell4ruG.1; Tue, 21 Apr 2015 22:21:36 -0700 From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21815.12255.713123.668054@ruffy2.mtv.corp.google.com> Date: Wed, 22 Apr 2015 05:23:00 -0000 To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v3 07/17] Misc switch_back_to_stepped_thread cleanups In-Reply-To: <1429267521-21047-8-git-send-email-palves@redhat.com> References: <1429267521-21047-1-git-send-email-palves@redhat.com> <1429267521-21047-8-git-send-email-palves@redhat.com> X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00812.txt.bz2 Pedro Alves writes: > [...] it isn't ever correct to pass step=1 to target_resume > on software single-step targets [...] Sounds like a good thing to document in a comment or assert. Can do? > , and currently_stepping works at a > conceptual higher level, it returns step=true even on software step > targets. It doesn't really matter on hardware step targets, as the > breakpoint will be hit immediately, but it's just wrong on software > step targets. I tested it against my x86 software single-step branch, > and it indeed fixes failed assertions (that catch spurious > PTRACE_SINGLESTEP requests) there. > > gdb/ChangeLog: > 2015-04-17 Pedro Alves > > * infrun.c (switch_back_to_stepped_thread): Use ecs->ptid instead > pf inferior_ptid. If the stepped thread vanished, return 0 > instead of resuming here. Use reset_ecs. Print the prev_pc and > the current stop_pc in log message. Clear trap_expected if the > thread advanced. Don't pass currently_stepping to > do_target_resume. >...