Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Doug Evans <dje@google.com>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH] dwarf2read.c (dw2_expand_symtabs_matching): Add some QUIT calls.
Date: Wed, 15 Apr 2015 21:35:00 -0000	[thread overview]
Message-ID: <21806.55683.577616.55845@ruffy2.mtv.corp.google.com> (raw)
In-Reply-To: <21806.51621.699064.799001@ruffy2.mtv.corp.google.com>

Doug Evans writes:
 > Doug Evans writes:
 >  > Hi.
 >  > 
 >  > "info fun foo" can be a pain when it's not interruptable,
 >  > especially if you're not exactly sure of what you're looking for
 >  > and provide something that matches too much.
 >  > 
 >  > 2015-03-30  Doug Evans  <dje@google.com>
 >  > 
 >  > 	* dwarf2read.c (dw2_expand_symtabs_matching): Add some QUIT calls.
 > 
 > Committed.

Hi.

I committed this corresponding patch.

There is a call to QUIT in recursively_search_psymtabs,
but I like the added symmetry and robustness.

[The astute reader may find that there are already QUIT calls
that can catch ^c's in this case.
E.g., dwarf2read.c calls out to c_print_type (IIRC)
which has a call to QUIT within it. However, there is a problem here
which I still have to address: these QUIT calls can leave symbol tables
partially constructed. Not sure how to fix this yet (I can think of
a couple of ways), and at any rate I like the explicit QUIT calls
that these two patches add.]

2015-04-15  Doug Evans  <dje@google.com>

	* psymtab.c (psym_expand_symtabs_matching): Add QUIT call.

diff --git a/gdb/psymtab.c b/gdb/psymtab.c
index b3c2f44..383e4c4 100644
--- a/gdb/psymtab.c
+++ b/gdb/psymtab.c
@@ -1423,6 +1423,8 @@ psym_expand_symtabs_matching
 
   ALL_OBJFILE_PSYMTABS_REQUIRED (objfile, ps)
     {
+      QUIT;
+
       if (ps->readin)
 	continue;
 


      reply	other threads:[~2015-04-15 21:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-30 23:29 Doug Evans
2015-04-15 20:27 ` Doug Evans
2015-04-15 21:35   ` Doug Evans [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21806.55683.577616.55845@ruffy2.mtv.corp.google.com \
    --to=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox