From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5741 invoked by alias); 9 Jan 2015 00:32:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5726 invoked by uid 89); 9 Jan 2015 00:32:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-vc0-f202.google.com Received: from mail-vc0-f202.google.com (HELO mail-vc0-f202.google.com) (209.85.220.202) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 09 Jan 2015 00:32:31 +0000 Received: by mail-vc0-f202.google.com with SMTP id hy10so482259vcb.1 for ; Thu, 08 Jan 2015 16:32:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:cc:subject:in-reply-to :references; bh=d+uyriTfKUkCk881N3EeuQG5kpIFH459YLxT70r0ZYE=; b=Ty8QHegBJY0oBUn8zCc8iItBo9ALyxHqvo+Bi7RnsgDga+WT+YzUisNjvExGpMWXIk L+gJBkcUy9ImB1FmMYhQeS+mR9bLy0h2kGh61IeucYFWbDFMLeHFHp5Yt8sAd9DLYD9o Vah9P2zbv+cTfJH96s7pxlcTlcE+T4mouTa2IOzcg74zxUFJYIaASxPo0eKo/wC8k4Zx 2FP6Larua4n5TJKo6BN3HplImR2UozRdDMwddVDId5YZsXTW5HB4eYM1MZlRM0abduA3 lKlVU+ICzGT/uWrWPe01Rz7Mr5zb/mxI8DjVAWqoBcmhJiQBfu3AGjPT7rUfW43OCmvU 7DxA== X-Gm-Message-State: ALoCoQnKVaKERjJKvWkW0ssYktDKOLxe7kFTc7x9VfXeesBhPuZwddNdr7rjj+5hf+6Ykn6FJRSd1b5Yk0XQ9TI0ux7jhbcqZfvzbBve73UNUz3eOeQQQXHwBu2awwEMPFcNa8g9fyA7AVLOrqFhyRJfFaIaC9VizYNBIw3t8JI2iLOxr5B0MO0= X-Received: by 10.224.86.2 with SMTP id q2mr8990639qal.1.1420763549335; Thu, 08 Jan 2015 16:32:29 -0800 (PST) Received: from corpmail-nozzle1-2.hot.corp.google.com ([100.108.1.103]) by gmr-mx.google.com with ESMTPS id u27si267744yhu.4.2015.01.08.16.32.28 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Jan 2015 16:32:29 -0800 (PST) Received: from ruffy2.mtv.corp.google.com ([172.17.128.107]) by corpmail-nozzle1-2.hot.corp.google.com with ESMTP id T3cNXTHP.1; Thu, 08 Jan 2015 16:32:29 -0800 From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21679.8603.893816.420021@ruffy2.mtv.corp.google.com> Date: Fri, 09 Jan 2015 00:32:00 -0000 To: Jan Kratochvil cc: gdb-patches@sourceware.org Subject: Re: ping^2: [patchv2] Fix 100x slowdown regression on DWZ files In-Reply-To: <21677.57646.178793.836948@ruffy2.mtv.corp.google.com> References: <21548.37770.274873.760290@ruffy2.mtv.corp.google.com> <20141002155653.GA9001@host2.jankratochvil.net> <20141231192335.GA8188@host2.jankratochvil.net> <21677.57646.178793.836948@ruffy2.mtv.corp.google.com> X-IsSubscribed: yes X-SW-Source: 2015-01/txt/msg00206.txt.bz2 Doug Evans writes: > Do hashtables support calling htab_find_slot with INSERT but then > not assigning the slot a value if it was empty? > I could be wrong but I think it does. > If so, we can remove one call to htab_find_slot here. I was wrong. I thought I was, but I couldn't remember, and couldn't remember where I had seen this. But htab_find_slot_with_hash does assume that if you call it with INSERT, and the slot isn't already used, then you're going to fill in the slot. No matter, it was just a thought.