From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44489 invoked by alias); 27 Mar 2018 10:33:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 44217 invoked by uid 89); 27 Mar 2018 10:33:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Mar 2018 10:33:18 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AF66040201A3; Tue, 27 Mar 2018 10:33:16 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 24A292026E03; Tue, 27 Mar 2018 10:33:15 +0000 (UTC) Subject: Re: [RFA] C++-ify typedef hash To: Tom Tromey References: <20180315215858.15647-1-tom@tromey.com> <6ace14da-cf07-4dd4-47a6-037c921eb129@redhat.com> <878taexlfl.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <2163f64d-42c9-0a7f-8745-f20a7f8b6c0a@redhat.com> Date: Tue, 27 Mar 2018 10:33:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <878taexlfl.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-03/txt/msg00554.txt.bz2 On 03/27/2018 04:10 AM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> At least this comment should be updated -- there's no "PRINTERS" > Pedro> parameter any longer. > > I just removed this comment, since I couldn't think of a useful comment > to put before a destructor. > >>> + /* Copy a typedef hash. */ >>> + typedef_hash_table (const typedef_hash_table *); > > Pedro> This method's prototype gave me pause -- is there a reason this > Pedro> isn't a regular copy ctor? > > I've changed it. I think this was something I meant to do and then > forgot to complete. > > Pedro> But FLAGS isn't a hash table, right? The original comment said: > Pedro> /* Look up the type T in the typedef hash table in with FLAGS. > Pedro> ^^^^^^^ > Pedro> I wonder whether that was a typo for "within". > Pedro> Maybe this could say something about local/global too. > > I've rewritten this comment, let me know what you think. LGTM. Thanks, Pedro Alves