Re: [RFA 04/42] Move last_source file to buildsym_compunit

Simon Marchi
2018-07-07T03:51:13Z

On 2018-05-23 12:58 AM, Tom Tromey wrote:
> @@ -140,6 +147,12 @@ struct buildsym_compunit
> /* The subfile of the main source file. */
> struct subfile *main_subfile = nullptr;
>
> + /* Name of source file whose symbol data we are now processing. This
> + comes from a symbol of type N_SO for stabs. For Dwarf it comes

I think it's spelled DWARF (all caps)?

> + from the DW_AT_name attribute of a DW_TAG_compile_unit DIE. */
> +
> + gdb::unique_xmalloc_ptr<char> m_last_source_file;

Nit: remove the empty line between the comment and the field.

Should this new field be private?

Otherwise, LGTM.

Simon