Re: [RFA 38/42] Introduce legacy-buildsym.h

Simon Marchi
2018-07-10T04:22:16Z

On 2018-05-23 12:58 AM, Tom Tromey wrote:
> This introduces a new header, legacy-buildsym.h, and changes all the
> symbol readers to use it. The idea is to put the function-based
> interface, that relies on the buildsym_compunit global, into a
> separate header. Then when a symbol reader is updated to use the new
> interface, it can simply not include legacy-buildsym.h, so it's easy
> to be sure that the new API is used everywhere.

Cool, good idea. I have two suggestions:

- Name it buildsym-legacy.h, so that it will be ordered right next to
buildsym.h in alphabetical lists.
- I would also create buildsym-legacy.c and move all the corresponding
definitions there, including the buildsym_compunit global variable.
I haven't actually tried it, maybe it's not possible and you have
already tried it though.

Simon