Re: [RFA 38/42] Introduce legacy-buildsym.h

Tom Tromey
2018-07-15T18:43:33Z

>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

Simon> On 2018-05-23 12:58 AM, Tom Tromey wrote:
>> This introduces a new header, legacy-buildsym.h, and changes all the
>> symbol readers to use it. The idea is to put the function-based
>> interface, that relies on the buildsym_compunit global, into a
>> separate header. Then when a symbol reader is updated to use the new
>> interface, it can simply not include legacy-buildsym.h, so it's easy
>> to be sure that the new API is used everywhere.

Simon> Cool, good idea. I have two suggestions:

Simon> - Name it buildsym-legacy.h, so that it will be ordered right next to
Simon> buildsym.h in alphabetical lists.
Simon> - I would also create buildsym-legacy.c and move all the corresponding
Simon> definitions there, including the buildsym_compunit global variable.
Simon> I haven't actually tried it, maybe it's not possible and you have
Simon> already tried it though.

I did these.
I think I've made it through all the review comments.
I'm running the result through the buildbot again & then I will
re-submit it. I think due to the number of rebases and edits required
it will need another round of review.

Tom