[RFA 26/42] Remove free_pendings

Tom Tromey
2018-05-23T04:59:20Z

buildsym.c currently keeps a free list of "struct pending"s. However,
this didn't seem necessary to me, and so this patch removes the free
list.

gdb/ChangeLog
2018-05-22 Tom Tromey <tom@tromey.com>

* buildsym.c (free_pendings): Remove.
(add_symbol_to_list, scoped_free_pendings)
(finish_block_internal, buildsym_init): Update.
---
gdb/ChangeLog | 6 ++++++
gdb/buildsym.c | 28 +++-------------------------
2 files changed, 9 insertions(+), 25 deletions(-)

diff --git a/gdb/buildsym.c b/gdb/buildsym.c
index 516dac6b7e..40176298a2 100644
--- a/gdb/buildsym.c
+++ b/gdb/buildsym.c
@@ -258,10 +258,6 @@ struct buildsym_compunit

static struct buildsym_compunit *buildsym_compunit;

-/* List of free `struct pending' structures for reuse. */
-
-static struct pending *free_pendings;
-
/* List of blocks already made (lexical contexts already closed).
This is used at the end to make the blockvector. */

@@ -303,16 +299,7 @@ add_symbol_to_list (struct symbol *symbol, struct pending **listhead)
don't have a link with room in it, add a new link. */
if (*listhead == NULL || (*listhead)->nsyms == PENDINGSIZE)
{
- if (free_pendings)
- {
- link = free_pendings;
- free_pendings = link->next;
- }
- else
- {
- link = XNEW (struct pending);
- }
-
+ link = XNEW (struct pending);
link->next = *listhead;
*listhead = link;
link->nsyms = 0;
@@ -360,13 +347,6 @@ scoped_free_pendings::~scoped_free_pendings ()
{
struct pending *next, *next1;

- for (next = free_pendings; next; next = next1)
- {
- next1 = next->next;
- xfree ((void *) next);
- }
- free_pendings = NULL;
-
for (next = file_symbols; next != NULL; next = next1)
{
next1 = next->next;
@@ -488,13 +468,12 @@ finish_block_internal (struct symbol *symbol,
if (static_link != NULL)
objfile_register_static_link (objfile, block, static_link);

- /* Now "free" the links of the list, and empty the list. */
+ /* Now free the links of the list, and empty the list. */

for (next = *listhead; next; next = next1)
{
next1 = next->next;
- next->next = free_pendings;
- free_pendings = next;
+ xfree (next);
}
*listhead = NULL;

@@ -1767,7 +1746,6 @@ buildsym_init ()
{
/* Ensure the scoped_free_pendings destructor was called after
the last time. */
- gdb_assert (free_pendings == NULL);
gdb_assert (file_symbols == NULL);
gdb_assert (global_symbols == NULL);
gdb_assert (buildsym_compunit == NULL);
--
2.13.6