Re: [RFA 29/42] Move the symbol lists to buildsym_compunit

Keith Seitz
2018-07-06T18:35:02Z

On 05/22/2018 09:58 PM, Tom Tromey wrote:
> diff --git a/gdb/buildsym.c b/gdb/buildsym.c
> index 40176298a2..0e21cfd83a 100644
> --- a/gdb/buildsym.c
> +++ b/gdb/buildsym.c
> @@ -251,6 +265,20 @@ struct buildsym_compunit
> are just waiting to be built into a blockvector when finalizing the
> associated symtab. */
> struct pending_block *m_pending_blocks = nullptr;
> +
> + /* Here are the three lists that symbols are put on. */
> +
> + /* static at top level, and types */
> +
> + struct pending *m_file_symbols = nullptr;
> +
> + /* global functions and variables */
> +
> + struct pending *m_global_symbols = nullptr;
> +
> + /* everything local to lexical context */
> +
> + struct pending *m_local_symbols = nullptr;
> };
>
> /* The work-in-progress of the compunit we are building.

I know these are all cut-n-paste descriptions, but could you please update them (incomplete sentences/grammar)?

[IANAM]

Thank you,
Keith