Re: [RFA 06/42] Move have_line_numbers to buildsym_compunit

Keith Seitz
2018-07-05T19:01:41Z

Hi,

I have just one trivial request:

On 05/22/2018 09:58 PM, Tom Tromey wrote:
> diff --git a/gdb/buildsym.c b/gdb/buildsym.c
> index c3961254da..d0dfa4cd02 100644
> --- a/gdb/buildsym.c
> +++ b/gdb/buildsym.c
> @@ -1288,7 +1286,7 @@ end_symtab_get_static_block (CORE_ADDR end_addr, int expandable, int required)
> && pending_blocks == NULL
> && file_symbols == NULL
> && global_symbols == NULL
> - && have_line_numbers == 0
> + && buildsym_compunit->m_have_line_numbers == 0
> && buildsym_compunit->m_pending_macros == NULL
> && global_using_directives == NULL)
> {

Since m_have_line_numbers was declared bool, I prefer (and I think most do?) that the comparison use `false' instead.

Keith