From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19342 invoked by alias); 4 Nov 2014 22:54:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19270 invoked by uid 89); 4 Nov 2014 22:54:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-oi0-f74.google.com Received: from mail-oi0-f74.google.com (HELO mail-oi0-f74.google.com) (209.85.218.74) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 04 Nov 2014 22:54:12 +0000 Received: by mail-oi0-f74.google.com with SMTP id u20so1795179oif.3 for ; Tue, 04 Nov 2014 14:54:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:cc:subject:in-reply-to :references; bh=P5wqbiLBNhHrUsH88JDPapNOVn00DxHwIJ9PBoC7csM=; b=g6JeDHQwq8z+LpUnjkI7Ve0oJOBkLtXv3jFNAUXLBy4lPsn7bEG87Hbx5cm5XuUclW FCn267sDe3Hl5+0LRqORsUaOQgbvzgdAmttLlGvNEl0qurUk5CanpCvosju+6vcjbnJD hT7v8oj5yFL3uaIJO4IBEjCFw4iEelPY4GzfE0TQZY3v+pfQMynO81WhmwW5XcodOUTG kVzYboTCHFvZtycZzqSs1pF+2CU7XyS+nXunCAGmw150zJUn5yMmfO3zkIKhUFK7gczu nfKBwyPKaTktvezIqpursa1TpZHGLjprg6S6rqQOP8Qx39Tzjq5FMOEDi5MKzqb32BEw M7XA== X-Gm-Message-State: ALoCoQlzIfVwK38DTETWQbzt++B5QlA2Zw/Wlmwenob11AcMHSAPXjn4fsD3mnN48WsDW90P2aW9E8bQwxUtg0xiWjhRaOSelgyZkpDqIHip++MIjzM0peBQrdk1dPaYU8uBDO7JuBS2vcZJI1VyrxK+t1jinfUP8G2snpB6oNNKTzgv9oT2D0g= X-Received: by 10.43.44.70 with SMTP id uf6mr1002194icb.2.1415141650791; Tue, 04 Nov 2014 14:54:10 -0800 (PST) Received: from corpmail-nozzle1-1.hot.corp.google.com ([100.108.1.104]) by gmr-mx.google.com with ESMTPS id r6si2610yhg.1.2014.11.04.14.54.10 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Nov 2014 14:54:10 -0800 (PST) Received: from ruffy2.mtv.corp.google.com ([172.17.128.107]) by corpmail-nozzle1-1.hot.corp.google.com with ESMTP id 4la4JhiW.1; Tue, 04 Nov 2014 14:54:10 -0800 From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21593.22801.679319.309936@ruffy2.mtv.corp.google.com> Date: Tue, 04 Nov 2014 22:54:00 -0000 To: Yao Qi Cc: Subject: Re: [PATCH 6/6] Fix dw2-ifort-parameter.exp fail with clang In-Reply-To: <1414195968-3333-7-git-send-email-yao@codesourcery.com> References: <1414195968-3333-1-git-send-email-yao@codesourcery.com> <1414195968-3333-7-git-send-email-yao@codesourcery.com> X-IsSubscribed: yes X-SW-Source: 2014-11/txt/msg00086.txt.bz2 Yao Qi writes: > The patch > fixed dw2-ifort-parameter.exp on powerpc64 by adding some labels to > get the start and end address of function func. This should also fix the > fail on thumb mode, however, this style is quite specific to gcc, and > other compiler, such as clang, may not guarantee the order of global > asms and functions. The test fails with clang: > > $ make check RUNTESTFLAGS='dw2-ifort-parameter.exp CC_FOR_TARGET=clang' > (gdb) p/x param^M > No symbol "param" in current context.^M > (gdb) FAIL: gdb.dwarf2/dw2-ifort-parameter.exp: p/x param > > With this patch applied, dw2-ifort-parameter.exp still passes for gcc > on arm thumb mode and popwerpc64, and it also passes for clang on > x86_linux. > > gdb/testsuite: > > 2014-10-24 Yao Qi > > * gdb.dwarf2/dw2-ifort-parameter.c: Remove inline asm. > (func): Add label func_label. > * gdb.dwarf2/dw2-ifort-parameter.exp (Dwarf::assemble): > Replace low_pc and high_pc with MACRO_AT_range. > Replace name, low_pc and high_pc with MACRO_AT_func. LGTM