From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18009 invoked by alias); 4 Nov 2014 22:53:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18000 invoked by uid 89); 4 Nov 2014 22:53:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f73.google.com Received: from mail-pa0-f73.google.com (HELO mail-pa0-f73.google.com) (209.85.220.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 04 Nov 2014 22:53:46 +0000 Received: by mail-pa0-f73.google.com with SMTP id lj1so2492435pab.4 for ; Tue, 04 Nov 2014 14:53:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:cc:subject:in-reply-to :references; bh=ZEpDk6D/yQW26Y24MjrkGOaLlQOua4G7mPQLp5C/wkI=; b=O57GPn8BDTb+jqsvVHrX9slV9PJvs0BDDBQxV6a+jbbVHYfIdwyeokaKWBLXQufHCd nxpzvOcFayJUtYOxKNzDBNpDT4fasEBcQqOjnVh/VkVPTGR4CTTR4V3m2ufZaMrudnSq O/p5c39UFG6/Fzos1uvrg/PeLks54U2PYXxTgXMFrAvYHs8OSP8EJlUtnpl5qvdJ5k3C hh8KIjYrvqkYA8CZsy9LV9X+zaLf1KQUixL2hiCI1Sos2vVrC3r/cOAzDmxmzJm51/hb U3zkXc3KtJTC+5zudmfvolLtK7KRK3ZrSxA1oZ5gG2c57uxwh/9fB4n5FzfOpIi0hjtK W5KA== X-Gm-Message-State: ALoCoQlP06OYN42p6tEgxgR7I+GBPh3MURsOcA7zv7RyhlenXOwWYEbNV938HeygUdURDzgMWU183pJxooMEx+wk1mj8TTcaajB/9fNoyicJPbrNc6+U3J6vCjM/ojWIlxwDVGlHZSmfDRVTkz+TShSMPzbr9LNAIJ8YD1L3XojmzLW8sUeLcuc= X-Received: by 10.66.253.41 with SMTP id zx9mr38190315pac.8.1415141624335; Tue, 04 Nov 2014 14:53:44 -0800 (PST) Received: from corpmail-nozzle1-1.hot.corp.google.com ([100.108.1.104]) by gmr-mx.google.com with ESMTPS id t28si35476yhb.4.2014.11.04.14.53.43 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Nov 2014 14:53:44 -0800 (PST) Received: from ruffy2.mtv.corp.google.com ([172.17.128.107]) by corpmail-nozzle1-1.hot.corp.google.com with ESMTP id kDbT13vz.1; Tue, 04 Nov 2014 14:53:44 -0800 From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21593.22775.246981.241989@ruffy2.mtv.corp.google.com> Date: Tue, 04 Nov 2014 22:53:00 -0000 To: Yao Qi Cc: Subject: Re: [PATCH 5/6] Fix implptr-optimized-out.exp fail In-Reply-To: <1414195968-3333-6-git-send-email-yao@codesourcery.com> References: <1414195968-3333-1-git-send-email-yao@codesourcery.com> <1414195968-3333-6-git-send-email-yao@codesourcery.com> X-IsSubscribed: yes X-SW-Source: 2014-11/txt/msg00085.txt.bz2 Yao Qi writes: > Hi, > I see the fail in gdb.dwarf2/implptr-optimized-out.exp in thumb mode > > (gdb) p p->f^M > No symbol "p" in current context.^M > (gdb) FAIL: gdb.dwarf2/implptr-optimized-out.exp: p p->f > > and the crash on powerpc64 > > (gdb) continue^M > Continuing.^M > ^M > Program received signal SIGSEGV, Segmentation fault.^M > 0x7d82100810000828 in ?? () > > The cause of both is that we incorrectly set attribute low_pc, since > main isn't resolved to function start address on these targets. > > In this patch, we replace attributes name, low_pc and high_pc with > MACRO_AT_func. The fail on thumb mode is fixed, and crash on > powerpc64 is fixed too. > > gdb/testsuite: > > 2014-10-24 Yao Qi > > * gdb.dwarf2/implptr-optimized-out.exp (Dwarf::assemble): > Replace name, low_pc and high_pc with MACRO_AT_func. LGTM