Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Doug Evans <dje@google.com>
To: Gary Benson <gbenson@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 01/13 v2] Introduce current_lwp_ptid
Date: Fri, 31 Oct 2014 18:57:00 -0000	[thread overview]
Message-ID: <21587.56225.942167.190@ruffy2.mtv.corp.google.com> (raw)
In-Reply-To: <1412848358-9958-2-git-send-email-gbenson@redhat.com>

Gary Benson writes:
 > This commit introduces a new function, current_lwp_ptid, that
 > shared Linux code can use to obtain the ptid of the current
 > lightweight process.
 > 
 > gdb/ChangeLog:
 > 
 > 	* nat/linux-nat.h (current_lwp_ptid): New declaration.
 > 	* linux-nat.c (current_lwp_ptid): New function.
 > 	* x86-linux-nat.c: Include nat/linux-nat.h.
 > 	(x86_linux_dr_get_addr): Use current_lwp_ptid.
 > 	(x86_linux_dr_get_control): Likewise.
 > 	(x86_linux_dr_get_status): Likewise.
 > 	(x86_linux_dr_set_control): Likewise.
 > 	(x86_linux_dr_set_addr): Likewise.
 > 
 > gdb/gdbserver/ChangeLog:
 > 
 > 	* linux-low.c (current_lwp_ptid): New function.
 > 	* linux-x86-low.c: Include nat/linux-nat.h.
 > 	(x86_dr_low_get_addr): Use current_lwp_ptid.
 > 	(x86_dr_low_get_control): Likewise.
 > 	(x86_dr_low_get_status): Likewise.
 > ---
 >  gdb/ChangeLog                 |   11 +++++++++++
 >  gdb/gdbserver/ChangeLog       |    8 ++++++++
 >  gdb/gdbserver/linux-low.c     |    8 ++++++++
 >  gdb/gdbserver/linux-x86-low.c |   13 ++++---------
 >  gdb/linux-nat.c               |    9 +++++++++
 >  gdb/nat/linux-nat.h           |    5 +++++
 >  gdb/x86-linux-nat.c           |   11 ++++++-----
 >  7 files changed, 51 insertions(+), 14 deletions(-)
 > 
 > diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c
 > index 8776670..6e1ed8a 100644
 > --- a/gdb/gdbserver/linux-low.c
 > +++ b/gdb/gdbserver/linux-low.c
 > @@ -6035,6 +6035,14 @@ linux_low_read_btrace (struct btrace_target_info *tinfo, struct buffer *buffer,
 >  }
 >  #endif /* HAVE_LINUX_BTRACE */
 >  
 > +/* See common/common-inferior.h.  */
 > +
 > +ptid_t
 > +current_lwp_ptid (void)
 > +{
 > +  return ptid_of (current_thread);
 > +}
 > +

Hi.

Nit I just noticed.  s,common/common-inferior.h,nat/linux-nat.h,


  parent reply	other threads:[~2014-10-31 18:57 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-09  9:53 [PATCH 00/13 v2] Refactor low-level Linux x86 debug register code Gary Benson
2014-10-09  9:53 ` [PATCH 04/13 v2] Make linux_stop_lwp be a shared function Gary Benson
2014-10-28 12:56   ` Pedro Alves
2014-10-09  9:53 ` [PATCH 01/13 v2] Introduce current_lwp_ptid Gary Benson
2014-10-28 12:56   ` Pedro Alves
2014-10-28 16:44     ` Doug Evans
2014-10-28 17:12       ` Doug Evans
2014-10-28 17:13         ` Doug Evans
2014-10-28 18:35       ` Pedro Alves
2014-10-28 19:43         ` Doug Evans
2014-10-31 18:57   ` Doug Evans [this message]
2014-10-09  9:53 ` [PATCH 02/13 v2] Add x86_debug_reg_state to gdbserver Gary Benson
2014-10-28 12:56   ` Pedro Alves
2014-10-09  9:54 ` [PATCH 12/13 v2] Move low-level Linux x86 debug register code to a shared file Gary Benson
2014-10-28 13:01   ` Pedro Alves
2014-10-09 10:18 ` [PATCH 07/13 v2] Make lwp_info.arch_private handling shared Gary Benson
2014-10-28 12:57   ` Pedro Alves
2014-10-09 10:18 ` [PATCH 05/13 v2] Introduce basic LWP accessors Gary Benson
2014-10-28 12:57   ` Pedro Alves
2014-10-09 10:18 ` [PATCH 03/13 v2] Add iterate_over_lwps to gdbserver Gary Benson
2014-10-28 12:56   ` Pedro Alves
2014-10-09 10:21 ` [PATCH 08/13 v2] Rename gdbserver's low-level Linux x86 debug register accessors Gary Benson
2014-10-28 12:58   ` Pedro Alves
2014-10-09 10:21 ` [PATCH 10/13 v2] Linux x86 low-level debug register comment synchronization Gary Benson
2014-10-28 12:59   ` Pedro Alves
2014-10-09 10:35 ` [PATCH 11/13 v2] Introduce x86_linux_update_debug_registers Gary Benson
2014-10-28 13:00   ` Pedro Alves
2014-10-09 10:35 ` [PATCH 06/13 v2] Change signature of linux_target_ops.new_thread Gary Benson
2014-10-28 12:57   ` Pedro Alves
2014-10-09 10:44 ` [PATCH 13/13 v2] Move duplicated Linux x86 code to nat/x86-linux.c Gary Benson
2014-10-28 13:01   ` Pedro Alves
2014-10-09 10:44 ` [PATCH 09/13 v2] Linux x86 low-level debug register code synchronization Gary Benson
2014-10-28 12:59   ` Pedro Alves
2015-03-24 14:11 ` [pushed] Refactor low-level Linux x86 debug register code Gary Benson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21587.56225.942167.190@ruffy2.mtv.corp.google.com \
    --to=dje@google.com \
    --cc=gbenson@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox