From: Doug Evans <dje@google.com>
To: Pedro Alves <palves@redhat.com>
Cc: Sandra Loosemore <sandra@codesourcery.com>,
gdb-patches@sourceware.org
Subject: Re: Cannot execute this command without a live selected thread.
Date: Fri, 24 Oct 2014 20:38:00 -0000 [thread overview]
Message-ID: <21578.47311.671976.969985@ruffy.mtv.corp.google.com> (raw)
In-Reply-To: <544AB48A.9080503@redhat.com>
Pedro Alves writes:
> > Not all targets use ptid.lwp.
>
> All process_stratum targets do.
windows-nat.c doesn't
(at least I remember seeing all calls to ptid_build there
passing 0 for lwp).
Could be missing something of course.
> I believe that on the GDB side too, it's best that we standardize on
> process_stratum targets using the ptid.lwp field to store thread ids
> anyway. The idea being leave the ptid.tid field free for any
> thread_stratum target that might want to sit on top.
The language in the comment in ptid.h waffles a bit:
process_stratum targets that handle threading themselves should
prefer using the ptid.lwp field, leaving the ptid.tid field for any
thread_stratum target that might want to sit on top.
Can we make this more of a rule than just a "should prefer"?
[and fix targets to follow]
next prev parent reply other threads:[~2014-10-24 20:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 15:55 Sandra Loosemore
2014-10-24 16:07 ` Pedro Alves
2014-10-24 17:08 ` Sandra Loosemore
2014-10-24 17:23 ` Pedro Alves
2014-10-24 17:40 ` Pedro Alves
2014-10-24 19:02 ` Sandra Loosemore
2014-10-24 19:19 ` Doug Evans
2014-10-24 19:40 ` Pedro Alves
2014-10-24 20:02 ` Doug Evans
2014-10-24 20:20 ` Pedro Alves
2014-10-24 20:38 ` Doug Evans [this message]
2014-10-24 20:52 ` Remove libthread_db -> remove thread_stratum? [was Re: Cannot execute this command without a live selected thread.] Doug Evans
2014-10-24 22:07 ` Cannot execute this command without a live selected thread Pedro Alves
2014-10-27 19:53 ` Sandra Loosemore
2014-10-28 12:10 ` [pushed] Workaround remote targets that report an empty list to qfThreadInfo (Re: Cannot execute this command without a live selected thread.) Pedro Alves
2014-10-29 19:16 ` Doug Evans
2014-10-24 17:57 ` Cannot execute this command without a live selected thread Sandra Loosemore
2014-10-24 18:15 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21578.47311.671976.969985@ruffy.mtv.corp.google.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=sandra@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox