From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10355 invoked by alias); 10 Oct 2014 22:03:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10345 invoked by uid 89); 10 Oct 2014 22:03:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f74.google.com Received: from mail-pa0-f74.google.com (HELO mail-pa0-f74.google.com) (209.85.220.74) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 10 Oct 2014 22:03:32 +0000 Received: by mail-pa0-f74.google.com with SMTP id kq14so496365pab.5 for ; Fri, 10 Oct 2014 15:03:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:cc:subject:in-reply-to :references; bh=m7LaPwqTKxDlNdF1u9Ri09LwYQKECeb7kpedpHlw/8g=; b=IDWPZuU6/zCrKVn3QGI28YfA1Q4I+fVy88oMuKH+s3UwgOly+v45mrwvk1VHDbKOI4 jhkOE85OcPp059gyU3mDal7VB8y8t60v+Q+BU8Fs4JX46D7v5aUTKeUEqa7sD5jQMKdb VAOXABNThjAPUs8EbuaLMUA5ziBrIDhAawSsxxzALD5c9TEX39bZXH2vcle2d2q951NW O6cEEioSZbA75tq7vw0bVlxf35te8ocQY+C/91SPK8bq3pa+OKA84l/i67KNdE03pHTF EAfJW/kG47k/RpXfDvwH1g+lXwbKMZQOvIqViQ/qV+coXkqhu7Pm4mnTAaK4gb2mJHU9 jxGg== X-Gm-Message-State: ALoCoQkQHZ0uE4Ggw5KUiUu9FFNqafiZQeMNqn3Y33wJJPIVcTTbbeGlSQM9StsTlcMX/qlwnPIym24auscXTOyJMzr24vK4Sv5tsUXELnNPTOIJm63rzA3Vp+H2bavbZr3+Z6fZLICVIZnlMnUadtFyqIKPDCpI16dSjrsWUgtn19hwdSmS7t0= X-Received: by 10.66.121.165 with SMTP id ll5mr221565pab.2.1412978610844; Fri, 10 Oct 2014 15:03:30 -0700 (PDT) Received: from corpmail-nozzle1-2.hot.corp.google.com ([100.108.1.103]) by gmr-mx.google.com with ESMTPS id n22si398030yhd.1.2014.10.10.15.03.30 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Oct 2014 15:03:30 -0700 (PDT) Received: from ruffy2.mtv.corp.google.com ([172.17.128.107]) by corpmail-nozzle1-2.hot.corp.google.com with ESMTP id l5vxymZQ.1; Fri, 10 Oct 2014 15:03:30 -0700 From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21560.22449.803178.90104@ruffy2.mtv.corp.google.com> Date: Fri, 10 Oct 2014 22:03:00 -0000 To: "Jose E. Marchesi" Cc: gdb-patches@sourceware.org Subject: Re: [PATCH V2 3/9] New commands `enable probe' and `disable probe'. In-Reply-To: <1412961772-16249-4-git-send-email-jose.marchesi@oracle.com> References: <1412961772-16249-1-git-send-email-jose.marchesi@oracle.com> <1412961772-16249-4-git-send-email-jose.marchesi@oracle.com> X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg00283.txt.bz2 Jose E. Marchesi writes: > This patch adds the above-mentioned commands to the generic probe > abstraction implemented in probe.[ch]. The effects associated to > enabling or disabling a probe depend on the type of probe being > handled, and is triggered by invoking two back-end hooks in > `probe_ops'. > > In case some particular probe type does not support the notion of > enabling and/or disabling, the corresponding fields on `probe_ops' can > be initialized to NULL. This is the case of SystemTap probes. > > gdb/ChangeLog: > > 2014-10-10 Jose E. Marchesi > > * stap-probe.c (stap_probe_ops): Add NULLs in the static > stap_probe_ops for `enable_probe' and `disable_probe'. > * probe.c (enable_probes_command): New function. > (disable_probes_command): Likewise. > (_initialize_probe): Define the cli commands `enable probe' and > `disable probe'. > (parse_probe_linespec): New function. > (info_probes_for_ops): Use parse_probe_linespec. > * probe.h (probe_ops): New hooks `enable_probe' and > `disable_probe'. > > gdb/doc/ChangeLog: > > 2014-10-10 Jose E. Marchesi > > * gdb.texinfo (Static Probe Points): Cover the `enable probe' and > `disable probe' commands. Hi. Would it be useful to have "info probes" show the enable/disable state of each probe? Or at least know which ones have been disabled. I can imagine wanting to know this information if something wasn't working the way I expected.