Re: [PATCH v8] Clarify GDBSERVER use in linux-waitpid.c

Pedro Alves
2014-09-12T10:05:45Z

On 09/12/2014 11:03 AM, Gary Benson wrote:
> Pedro Alves wrote:
>> Sorry, but now that I see it, IMO the end up resulting code
>> doesn't really look better than what we already have. :-/
>> We end up with #ifdef GDBSERVER anyway, so might be best to
>> either leave this be until we come up with a complete solution.
>
> Ok, how about this:
>
> This commit makes linux-waitpid.c include common-defs.h. GDB's
> inclusion of defs.h is removed, but gdbserver's inclusion of
> server.h remains to support some gdbserver-specific debug code
> that cannot presently be merged. A new FIXME documents this.
>
> gdb/ChangeLog:
>
> * nat/linux-waitpid.c: Include common-defs.h.
> [GDBSERVER]: Add FIXME comment.
> [!GDBSERVER]: Don't include defs.h or signal.h.
> (linux_debug) [!GDBSERVER]: Remove empty block.

OK.

Thanks,
Pedro Alves