From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23371 invoked by alias); 12 Sep 2014 17:38:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23359 invoked by uid 89); 12 Sep 2014 17:38:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vc0-f201.google.com Received: from mail-vc0-f201.google.com (HELO mail-vc0-f201.google.com) (209.85.220.201) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 12 Sep 2014 17:38:40 +0000 Received: by mail-vc0-f201.google.com with SMTP id hy4so102820vcb.4 for ; Fri, 12 Sep 2014 10:38:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:cc:subject:in-reply-to :references; bh=rLoeVYnOQ+hXLHZyb/nuTPdVjgyQW32eZEnYDCa3z2c=; b=B+/RR7cxgH2ia49KPcuh4jbkqoEdbNTbIZGk9KEE57XtmSvZF3ujrhvANhYVFvXSue V7CDpX07ShtJj2CPgvMT59OJSk7fy8lCNrq2LMuPnUZIqz3hzqT0EoglpV+LTsK+FvV3 yLgdFXWKxHJvqrtP9BbiVmUrjzQReaC2+6ZD8yXFT5MaaW3kuQkXPDF40O6aaxaaLYW/ h696EPX/qsllz+IagvKCuWLvfXjsdKCJTMGA5SGjbCI8Eh++53CPf9wqcJRoQDOEv8qS U36pCcuXtKEGaiaSu2d6nsej/HLaAluhFxMqdLjL/7Zxyrv6Np+Wpiwq/1jR122D+uzE iZmQ== X-Gm-Message-State: ALoCoQmwTGlhYw8zj2CYXa516uoADDe8/GxEq5MXNbg49UAY66bqP/LHlNHNI7LqvVdy704AmRPco8olZIy1WETxRfn8fALzmLlqOGnfd6IPGwotMP3aDkkI5ef4ARee2TdJi6I4RAieFGEhVB3vXgT14tCjYHB73mFc/qmndcNtV7Wk6xYggFY= X-Received: by 10.52.252.42 with SMTP id zp10mr5266712vdc.6.1410543518316; Fri, 12 Sep 2014 10:38:38 -0700 (PDT) Received: from corpmail-nozzle1-1.hot.corp.google.com ([100.108.1.104]) by gmr-mx.google.com with ESMTPS id m14si208996yhm.7.2014.09.12.10.38.37 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 12 Sep 2014 10:38:38 -0700 (PDT) Received: from ruffy2.mtv.corp.google.com ([172.17.128.107]) by corpmail-nozzle1-1.hot.corp.google.com with ESMTP id V2QoI5o8.1; Fri, 12 Sep 2014 10:38:38 -0700 From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21523.12189.134570.770432@ruffy2.mtv.corp.google.com> Date: Fri, 12 Sep 2014 17:38:00 -0000 To: Pedro Alves Cc: Gary Benson , gdb-patches@sourceware.org Subject: Re: [PATCH 3/9 v7] Introduce target_{stop,continue}_ptid In-Reply-To: <54132B55.9000108@redhat.com> References: <1409320299-6812-1-git-send-email-gbenson@redhat.com> <1409320299-6812-4-git-send-email-gbenson@redhat.com> <21520.36381.756875.963606@ruffy2.mtv.corp.google.com> <20140911102659.GA17472@blade.nx> <5412DEB5.6020706@redhat.com> <21523.9502.168492.803068@ruffy2.mtv.corp.google.com> <54132B55.9000108@redhat.com> X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg00443.txt.bz2 Pedro Alves writes: > On 09/12/2014 05:53 PM, Doug Evans wrote: > > > That may be sufficient for me to make this patch checkin-able, > > but before then I'd like to understand how and where > > this function will be used from gdb. > > Can you clarify? I don't have any plan to use this > elsewhere myself. All we're doing is factoring out > the current use behind a common function so that both gdb > and gdbserver can implement it their own way. I don't see the function being used in gdb by this patch set. So, absent further info, the change to gdb/target.c is just adding dead code. I'm assuming that's not the case (*1), but until I understand how it's going to be used in gdb it's not clear to me whether code that uses it will be confusing to read. (*1): I could have missed its use. But even if it's dead code today, I don't mind it in this particular case. > > btw, how about target_continue_with_no_signal (ptid_t ptid) ? > > Fine with me. In which case I'm happy. Code that uses that name can be read unambiguously (to me anyway).