Re: [PATCH 3/9 v7] Introduce target_{stop,continue}_ptid

Pedro Alves
2014-09-16T10:45:11Z

On 09/16/2014 10:49 AM, Gary Benson wrote:

>
> c) The bug is that in this code in linux-nat.c:
>
> /* Pause all */
> target_stop (ptid);
>
> memcpy (s, "qTfSTM", sizeof ("qTfSTM"));
> s[sizeof ("qTfSTM")] = 0;
>
> agent_run_command (pid, s, strlen (s) + 1);
>
> the "target_stop" should actually be a call to whatever
> target_stop_ptid is renamed to.
>
> One final thing--and I may now be going over something that has been
> discussed before--could target_continue_ptid be better renamed as
> target_resume_no_signal? It seems to sit better alongside GDB's
> target_resume.

No, the "resume" interface can "continue" and "step" (and on gdbserver,
stop/interrupt too), but target_continue_ptid _only_ continues.

Thanks,
Pedro Alves