Re: [PATCH 9/9 v7] Remove one GDBSERVER use from linux-waitpid.c

Pedro Alves
2014-09-10T13:29:37Z

On 08/29/2014 02:51 PM, Gary Benson wrote:

>
> -static unsigned int debug_linux_nat;
> +unsigned int debug_linux_nat;
> +

> +#define debug_linux_waitpid debug_linux_nat
> #endif

> +extern int debug_linux_waitpid;
>

The dangers of extern... This ends up undefined code, as
the variable is defined as signed, and then declared here
as signed.

Sorry, but now that I see it, IMO the end up resulting code
doesn't really look better than what we already have. :-/ We
end up with #ifdef GDBSERVER anyway, so might be best to
either leave this be until we come up with a complete solution.

Thanks,
Pedro Alves