From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4704 invoked by alias); 29 Aug 2014 12:38:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4695 invoked by uid 89); 29 Aug 2014 12:38:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ie0-f202.google.com Received: from mail-ie0-f202.google.com (HELO mail-ie0-f202.google.com) (209.85.223.202) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 29 Aug 2014 12:38:55 +0000 Received: by mail-ie0-f202.google.com with SMTP id rl12so517069iec.3 for ; Fri, 29 Aug 2014 05:38:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:cc:subject:in-reply-to :references; bh=D0bWPToKOV2R/J8chtTKKFkE5RtSx7J9JYYvobjFlwM=; b=ZLZ72yT+g9cY8QlUr/gFHoHUxiKN136bo0zupqUJ111IdZY/7qZ01YW57mP5J+IxbJ NvMHdV+tRnEjKTJ3oMHV6/iMjAMPJZzTuXDwnFYAVu7TIiRYBVvA0ziQKqdf2pTETkgo 5TQaw6OZM46ACvKodZeVLowt4GkJ4RO+WXAk/grFeax6pnUglz2U7ZtPaWg7am10aIaE e2A/Bep4db8pR7FyIWnF7c2XtzTynD5aHVLLoNBGb+F1EAPlK64FgFTb51fOOwZg7hye 8ZSrNbcqgwSzxaWZfM1VKi8htnp/BwWwsxOQseU5pUQuvnlyVoBn4qzkoS9FlGugS1xz ldAg== X-Gm-Message-State: ALoCoQkNGuHTArz5mVx7jKshBs9O5tN3t8LBVWYOEYaENoLWPKXNGKWYKTsnFVIfW0ucRQpr8GA3 X-Received: by 10.50.28.68 with SMTP id z4mr1950614igg.2.1409315932757; Fri, 29 Aug 2014 05:38:52 -0700 (PDT) Received: from corp2gmr1-2.hot.corp.google.com (corp2gmr1-2.hot.corp.google.com [172.24.189.93]) by gmr-mx.google.com with ESMTPS id h24si382082yhb.6.2014.08.29.05.38.52 for (version=TLSv1.1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 29 Aug 2014 05:38:52 -0700 (PDT) Received: from ruffy2.mtv.corp.google.com (ruffy2.mtv.corp.google.com [172.17.128.107]) by corp2gmr1-2.hot.corp.google.com (Postfix) with ESMTP id 580B42F5F27; Thu, 28 Aug 2014 14:54:00 -0700 (PDT) From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21503.42231.813828.804626@ruffy2.mtv.corp.google.com> Date: Fri, 29 Aug 2014 12:38:00 -0000 To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch] [testsuite] Fix running in-src-dir in the same directory twice In-Reply-To: <20140828211010.GA4960@host2.jankratochvil.net> References: <20140828211010.GA4960@host2.jankratochvil.net> X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00639.txt.bz2 Jan Kratochvil writes: > Hi, > > ./configure; make; cd gdb; make check; make check > -> > Running ./gdb.base/argv0-symlink-dirlink/a2-run.exp ... > Running ./gdb.base/argv0-symlink-dirlink/advance.exp ... > Running ./gdb.base/argv0-symlink-dirlink/argv0-symlink-dirlink/a2-run.exp ... > Running ./gdb.base/argv0-symlink-dirlink/argv0-symlink-dirlink/advance.exp ... > Running ./gdb.base/argv0-symlink-dirlink/argv0-symlink-dirlink/argv0-symlink-dirlink/argv0-symlink-dirlink/argv0-symlink-dirlink/argv0-symlink-dirlink/argv0-symlink-dirlink/argv0-symlink-dirlink/argv0-symlink-dirlink/argv0-symlink-dirlink/argv0-symlink-dirlink/argv0-symlink-dirlink/argv0-symlink-dirlink/argv0-symlink-dirlink/argv0-symlink-dirlink/argv0-symlink-dirlink/argv0-symlink-dirlink/argv0-symlink-dirlink/argv0-symlink-dirlink/argv0-symlink-dirlink/argv0-symlink-dirlink/argv0-symlink-dirlink/argv0-symlink-dirlink/argv0-symlink-dirlink/argv0-symlink-dirlink/argv0-symlink-dirlink/argv0-symlink-dirlink/argv0-symlink-dirlink/argv0-symlink-dirlink/argv0-symlink-dirlink/argv0-symlink-dirlink/argv0-symlink-dirlink/argv0-symlink-dirlink/argv0-symlink-dirlink/argv0-symlink-dirlink/argv0-symlink-dirlink/argv0-symlink-dirlink/argv0-symlink-dirlink/argv0-symlink-dirlink/argv0-symlink-dirlink/double-prompt-target-event-error.exp ... > > particularly I was testing it with: > cp -a testsuite/ testsuite-clean;make -C testsuite/ -k -j1 check;cp -a testsuite/ testsuite-pass1;make -C testsuite/ -k -j1 check;cp -a testsuite/ testsuite-pass2 > > (The second run still has many FAILs due to deleted source files but that is > a different patch going to be posted.) > > > Thanks, > Jan > gdb/testsuite/ > 2014-08-28 Jan Kratochvil > > Fix running in-src-dir testsuite in the same directory twice. > * gdb.base/argv0-symlink.exp: Delete $dirlink. > > diff --git a/gdb/testsuite/gdb.base/argv0-symlink.exp b/gdb/testsuite/gdb.base/argv0-symlink.exp > index d849b4c..39aab9c 100644 > --- a/gdb/testsuite/gdb.base/argv0-symlink.exp > +++ b/gdb/testsuite/gdb.base/argv0-symlink.exp > @@ -59,6 +59,7 @@ set dirlink "${testfile}-dirlink" > remote_exec host "rm -f [standard_output_file $dirlink]" > set status [remote_exec host "ln -sf . [standard_output_file $dirlink]"] > if {[lindex $status 0] != 0} { > + remote_exec host "rm -f [standard_output_file $dirlink]" > unsupported "$test (host does not support symbolic links)" > return 0 > } > @@ -66,6 +67,7 @@ if {[lindex $status 0] != 0} { > clean_restart "$dirlink/$filelink" > > if ![runto_main] { > + remote_exec host "rm -f [standard_output_file $dirlink]" > untested "could not run to main" > return -1 > } > @@ -79,3 +81,8 @@ if ![is_remote target] { > } > gdb_test {print argv[0]} "/$dirlink/$filelink\"" $test > gdb_test "info inferiors" "/$lastdir/$filelink *" "$test for info inferiors" > + > +# Stale directory symlink would deadlock runtest: > +# Running ./gdb.base/argv0-symlink-dirlink/a2-run.exp ... > +# Running ./gdb.base/argv0-symlink-dirlink/argv0-symlink-dirlink/a2-run.exp ... > +remote_exec host "rm -f [standard_output_file $dirlink]" Tests can prematurely terminate for various unanticipatable reasons. Can this be solved by making sure any possibly hazardous left over files are cleaned up at start?