From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 8ED6C385DC1B for ; Wed, 15 Apr 2020 17:54:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8ED6C385DC1B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 0A4C91E60C; Wed, 15 Apr 2020 13:54:20 -0400 (EDT) From: Simon Marchi Subject: Re: [PATCH v3 21/29] Share handle_exception To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20200313190855.28662-1-tromey@adacore.com> <20200313190855.28662-22-tromey@adacore.com> <33cddd77-b9c5-dfaa-78cb-2812016b07fd@simark.ca> <87tv1kadv4.fsf@tromey.com> Message-ID: <214bbace-933a-a99e-1fcd-0956b6b4a5bd@simark.ca> Date: Wed, 15 Apr 2020 13:54:19 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <87tv1kadv4.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Apr 2020 17:54:23 -0000 On 2020-04-15 12:54 p.m., Tom Tromey wrote: > Simon> This patch introduced some GDB-specific calls in nat/windows-nat.c. That > Simon> file is built by gdbserver, so it breaks that build. This is when building > Simon> on Cygwin: > > For reasons I don't really understand, I can't seem to do a Cygwin > build. (And, I have little control over the Windows machines I do have > access to, so I can't really fix the problem, whatever it is.) > > So, could you try this patch? > > Tom It helps, but there's still: CXX nat/windows-nat.o /home/smarchi/src/binutils-gdb/gdbserver/../gdb/nat/windows-nat.c: In function ‘windows_nat::handle_exception_result windows_nat::handle_exception(target_waitstatus*, bool)’: /home/smarchi/src/binutils-gdb/gdbserver/../gdb/nat/windows-nat.c:214:10: error: ‘find_pc_partial_function’ was not declared in this scope 214 | || (find_pc_partial_function (addr, &fn, NULL, NULL) | ^~~~~~~~~~~~~~~~~~~~~~~~ But even if that did build, I don't think it's right. That code will be used by gdbserver, which will never initialize cygwin_load_start and cygwin_load_end. If we look at gdbserver's version of the function before this change, it didn't have that part, so perhaps it should be factored out into a callback, which will reside in gdb/windows-nat.c. Simon