From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12422 invoked by alias); 22 Aug 2014 18:06:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12410 invoked by uid 89); 22 Aug 2014 18:06:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ie0-f202.google.com Received: from mail-ie0-f202.google.com (HELO mail-ie0-f202.google.com) (209.85.223.202) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 22 Aug 2014 18:06:41 +0000 Received: by mail-ie0-f202.google.com with SMTP id rl12so988964iec.1 for ; Fri, 22 Aug 2014 11:06:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:cc:subject:in-reply-to :references; bh=AJheamUeCT7EPYw4aJldZJOoxSTUofKfHNQsW+JdSWI=; b=fNDgyLfVmJSqH/GZrxmlWplB2g9jKi9ji6aEj0TWZqLnWCk6o/nRfSxNADx+PVvbMs y8F1AYv5lmAQDvKURia4UTGZpHltR49nLesw9pxmQTQKeoWmBqIqR5y+u0ErHMa9DpCj 11zoCZeFPITAoJSd6NTLu0z3nRW7xl5WV33uP++UtXTERTfiGne6LwYlBHezYtsLrcb/ rpdSECrtdktMY2ObA6Hr3azwd5IVIN/rJsiM6ZuWLsTFvNCJApuOsVkTvikg/VVtCZAR VUsSX4saHWeUhBe69qLCNtxblMIKN94o25ISvVj58i9JVjQw20KRbWyf5xAB6idbnNxx 7fEQ== X-Gm-Message-State: ALoCoQkM+hM4YeHkaUZtnk1egj5AVf4LCNqhL5aY+66xu1hKJK9ksCFScOe+6ayvDHJ7sElZA6Jh X-Received: by 10.50.117.10 with SMTP id ka10mr166896igb.1.1408730799246; Fri, 22 Aug 2014 11:06:39 -0700 (PDT) Received: from corp2gmr1-2.hot.corp.google.com (corp2gmr1-2.hot.corp.google.com [172.24.189.93]) by gmr-mx.google.com with ESMTPS id a66si1110058yhg.7.2014.08.22.11.06.39 for (version=TLSv1.1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 22 Aug 2014 11:06:39 -0700 (PDT) Received: from ruffy2.mtv.corp.google.com (ruffy2.mtv.corp.google.com [172.17.128.107]) by corp2gmr1-2.hot.corp.google.com (Postfix) with ESMTP id B058A5A41F2; Fri, 22 Aug 2014 11:06:38 -0700 (PDT) From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21495.34478.167560.633885@ruffy2.mtv.corp.google.com> Date: Fri, 22 Aug 2014 18:06:00 -0000 To: Yao Qi Cc: Subject: Re: [PATCH 3/3] Run dw2-var-zero-addr.exp with --readnow In-Reply-To: <1408609338-17561-3-git-send-email-yao@codesourcery.com> References: <53D8A264.1050103@codesourcery.com> <1408609338-17561-1-git-send-email-yao@codesourcery.com> <1408609338-17561-3-git-send-email-yao@codesourcery.com> X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00505.txt.bz2 Yao Qi writes: > This patch is to extend dw2-var-zero-add.exp to test the case that > partial symtabl is not used while full symtab is used, in order to > cover the changes in patch 2/3. This patch restarts GDB with > --readnow and does the same test again. > > gdb/testsuite: > > 2014-08-20 Yao Qi > > * gdb.dwarf2/dw2-var-zero-addr.exp: Move test into new proc test. > Invoke test. Restart GDB with --readnow and invoke test again. > --- > gdb/testsuite/gdb.dwarf2/dw2-var-zero-addr.exp | 20 +++++++++++++++++--- > 1 file changed, 17 insertions(+), 3 deletions(-) > > diff --git a/gdb/testsuite/gdb.dwarf2/dw2-var-zero-addr.exp b/gdb/testsuite/gdb.dwarf2/dw2-var-zero-addr.exp > index 462a5f8..5e1732b 100644 > --- a/gdb/testsuite/gdb.dwarf2/dw2-var-zero-addr.exp > +++ b/gdb/testsuite/gdb.dwarf2/dw2-var-zero-addr.exp > @@ -26,6 +26,20 @@ if [prepare_for_testing ${testfile}.exp ${testfile} \ > return -1 > } > > -# FAIL was: = (int *) 0x0 > -# Such DIE record can be produced using: gcc -fdata-sections -Wl,-gc-sections > -gdb_test "print &var" {No symbol "var" in current context\.} > +proc test { } { > + # FAIL was: = (int *) 0x0 > + # Such DIE record can be produced using: gcc -fdata-sections -Wl,-gc-sections > + gdb_test "print &var" {No symbol "var" in current context\.} > +} > + > +test > + > +global GDBFLAGS This global is unnecessary. Otherwise the patch is fine by me. [I kinda wonder whether the name "test" should be slightly more descriptive, but I guess I'm ok with it as is.] > +set saved_gdbflags $GDBFLAGS > +set GDBFLAGS "$GDBFLAGS --readnow" > +clean_restart ${binfile} > +set GDBFLAGS $saved_gdbflags > + > +with_test_prefix "readnow" { > + test > +}