From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29591 invoked by alias); 21 Aug 2014 17:32:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29582 invoked by uid 89); 21 Aug 2014 17:32:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ob0-f201.google.com Received: from mail-ob0-f201.google.com (HELO mail-ob0-f201.google.com) (209.85.214.201) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 21 Aug 2014 17:32:20 +0000 Received: by mail-ob0-f201.google.com with SMTP id va2so1443608obc.0 for ; Thu, 21 Aug 2014 10:32:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:cc:subject:in-reply-to :references; bh=niwrxsbjmh7weQD5KVn1/xllQ+oS3OXB/ZTl0QexN4U=; b=R6z1WMb8r3x14VFbCXFvGMgvTE4HRbxUcmfcuCwuOoBzX+4MvKo8YFh9mvwc5EP9ld LbDRF83RO4TIm4oTfi+7jiBW3MohT/7oip3z9JBXU5K/ll6dWLNKmbmJYSnPmz48jJup AzMjgb9IXDCBepLq/q7FMCHpAxezZkncv9N2qRZYURGhKQdEY/j174bd4B8hVC/w8biT n32GfCmOFu5BikbmDnUGgh0dYQG8vTI3zuHEtQG0AqzwVq5XdLvB5LWMo2Jn0fGAzXrx ILhl+druiOMceeuSV7mstA4NKaboXD4pWCRCXW0qpQNY6LvIK5x1EXNV21dIj0FpHDrF vz5A== X-Gm-Message-State: ALoCoQkbOyx/8QnEqV2+5Iaag0W9pA0r2oNaDqnYF+eZbtem5HvUIJKJE9MmZ+tlPlxz/YhLclNB X-Received: by 10.50.80.111 with SMTP id q15mr3339134igx.0.1408642338108; Thu, 21 Aug 2014 10:32:18 -0700 (PDT) Received: from corp2gmr1-1.hot.corp.google.com (corp2gmr1-1.hot.corp.google.com [172.24.189.92]) by gmr-mx.google.com with ESMTPS id o69si849223yhp.6.2014.08.21.10.32.18 for (version=TLSv1.1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 21 Aug 2014 10:32:18 -0700 (PDT) Received: from ruffy2.mtv.corp.google.com (ruffy2.mtv.corp.google.com [172.17.128.107]) by corp2gmr1-1.hot.corp.google.com (Postfix) with ESMTP id 8EEF431CAAA; Thu, 21 Aug 2014 10:32:17 -0700 (PDT) From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=unknown Content-Transfer-Encoding: 7bit Message-ID: <21494.11553.21635.800922@ruffy2.mtv.corp.google.com> Date: Thu, 21 Aug 2014 17:32:00 -0000 To: Yao Qi Cc: gdb-patches Subject: Re: [PATCH 0/3] Keep track of files copied to host and target In-Reply-To: <53F53DE9.3070702@codesourcery.com> References: <1408075184-25947-1-git-send-email-yao@codesourcery.com> <53EDA303.90701@codesourcery.com> <53F4452E.9070902@codesourcery.com> <21492.50006.332014.650387@ruffy2.mtv.corp.google.com> <53F53DE9.3070702@codesourcery.com> X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00487.txt.bz2 Yao Qi writes: > On 08/20/2014 11:48 PM, Doug Evans wrote: > > How about separating out 3/3 from the rest of the patch set. > > We can fix this part now, and unblock that from the discussion of > > the rest of the patch set. > > That sounds good to me. In fact patch 3/3 is independent and can be > used as-is. I update commit log a little bit to explain why *.py files > are not removed on host. Is it OK? > > -- > Yao ( ) > > Subject: [PATCH] Copy .py files to remote host > > Some gdb.python/*.exp tests fail because the .py files aren't copied > to the (remote) host. This patch is to copy needed .py files to host. > Most of gdb.python/*.exp tests do this. > > As it is still controversial to delete *.py files on host, we don't do > that in this patch. > > gdb/testsuite: > > 2014-08-21 Yao Qi > > * gdb.python/py-finish-breakpoint.exp: Copy .py file to host. > * gdb.python/py-finish-breakpoint2.exp: Likewise. > * gdb.python/python.exp: Likewise. Use .py file on the host > instead of the build. LGTM For reference sake, It seems there's a roughly equal measure of usage of remote_download versus gdb_remote_download in the testsuite for downloading to the host (though I didn't count which usages of gdb_remote_download actually need its extra functionality). Long term, if you wanted to migrate other uses of remote_download to gdb_remote_download for nothing other than consistency's sake that would be fine with me.