From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9385 invoked by alias); 14 Aug 2014 22:35:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9370 invoked by uid 89); 14 Aug 2014 22:35:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-oi0-f73.google.com Received: from mail-oi0-f73.google.com (HELO mail-oi0-f73.google.com) (209.85.218.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 14 Aug 2014 22:35:01 +0000 Received: by mail-oi0-f73.google.com with SMTP id u20so390157oif.4 for ; Thu, 14 Aug 2014 15:35:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:cc:subject:in-reply-to :references; bh=tek+JtYMAAe8i9yeFjeqJbgO1E2+e3yPNzKRE2hrCkM=; b=jtv7GHvaKfq0CID5PvB1+/lyxL2htmomRwts5D/oQ67wnH02KxD0mxN+FsO5OstFwE nIoXKpfNHFXHtqiFBwMjvbMf/3xYA2AuchMj9fF4J7zDll4GVu9viLDJIoVX/TWfO9TR Uw+H0hPd3OnAE9cUcKQ0XiKzDViSCyHJ767XXSRu6b+WYEBxQsZcU1t9yXK2SLmP85OW dUOnIwwsWUlR150abnXy6rj3AUPwZYeQPJO4vcvwCNG5kg6pPTHAr2qYLMPeKLCxjePd SZfao/PbZLMFZFunfL4PsgCbxduiDnyK7egcvEee8KZ6f9cZ+zs494/5ffQRe26A6dRl +w/Q== X-Gm-Message-State: ALoCoQmJ9lJqixDWApMQG0fSbM7v6U7wCUjWuvUrI+LS+QZ6YaGdV3rmqoK94pbucWbnk+AmGqWU X-Received: by 10.50.23.45 with SMTP id j13mr7894872igf.7.1408055700017; Thu, 14 Aug 2014 15:35:00 -0700 (PDT) Received: from corp2gmr1-1.hot.corp.google.com (corp2gmr1-1.hot.corp.google.com [172.24.189.92]) by gmr-mx.google.com with ESMTPS id a66si466341yhg.7.2014.08.14.15.34.59 for (version=TLSv1.1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 14 Aug 2014 15:34:59 -0700 (PDT) Received: from ruffy.mtv.corp.google.com (ruffy.mtv.corp.google.com [172.17.128.44]) by corp2gmr1-1.hot.corp.google.com (Postfix) with ESMTP id 779F031C233; Thu, 14 Aug 2014 15:34:59 -0700 (PDT) From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21485.14738.947462.758709@ruffy.mtv.corp.google.com> Date: Thu, 14 Aug 2014 22:35:00 -0000 To: Siva Chandra Cc: gdb-patches Subject: Re: [PATCH v2] Fix xmethod Python so that it works with Python 3 In-Reply-To: References: X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00254.txt.bz2 Siva Chandra writes: > The attached patch fixes the "no space before parenthesis in Python" > comment by Joel. The comment was for the changes in the test suite. > Going by examples, I thought the test case code (but not the .exp > files) did not require adherence to coding style. > > I also agree with Joel that this patch should also pushed to the 7.8 branch. > > ChangeLog: > 2014-08-14 Siva Chandra Reddy > > gdb/ > > * python/lib/gdb/command/xmethods.py (set_xm_status1): Use the > 'items' methods instead of 'iteritems' method on dictionaries. > > gdb/testsuite/ > > * gdb.python/py-xmethods.py (A_getarrayind) > (E_method_char_worker.__call__, E_method_int_worker.__call__): > Use 'print' with function call syntax. > (E_method_matcher.match): Fix tab vs space indentation mixup. LGTM