From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7408 invoked by alias); 6 Aug 2014 17:26:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7332 invoked by uid 89); 6 Aug 2014 17:26:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ob0-f202.google.com Received: from mail-ob0-f202.google.com (HELO mail-ob0-f202.google.com) (209.85.214.202) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 06 Aug 2014 17:26:31 +0000 Received: by mail-ob0-f202.google.com with SMTP id wp18so531069obc.3 for ; Wed, 06 Aug 2014 10:26:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:cc:subject:in-reply-to :references; bh=NamMrIlrqhTaXf8m/Rll/g+GLNrdwIK0YgFh9xcX7/w=; b=TdWfiDkha0SCGyRbyW5+ul1W+F6sXLQLmMvOnR9Ip9QUrUx1lvUXRmQpa38rwPEC++ JpdP4xDyf6DFnGB2ycS5WBphQTfo6KuyW2FfrysJdCEDc9FHTV33HtYIT1CbxbC0c7Qa EofVyPoEICQACE9nIttxgBXhu7pHNqHKZW78xypkbua5i+SnaXdUFY7A8IovAteBAmae YbMeiOsdMhPTtzSF602DCQQV8NB47+4I0f0TzDSI112FcGALgyCfs1jZJfbh9QM722Yy buAofdjly0eyinZz2tL2oZEiXzUvzZfv9mG39IESFlMNKEav92NBRCJHtYuJ2ak8mpwT R+Rg== X-Gm-Message-State: ALoCoQkBS/649GFi0kPYfTypLetb9S8dxujP8+BME4SOs0nB0hGZgt8GUxbQKELZZ/HpZ4qK6Zlx X-Received: by 10.42.188.84 with SMTP id cz20mr6796523icb.1.1407345989568; Wed, 06 Aug 2014 10:26:29 -0700 (PDT) Received: from corp2gmr1-1.hot.corp.google.com (corp2gmr1-1.hot.corp.google.com [172.24.189.92]) by gmr-mx.google.com with ESMTPS id v20si106026yhe.2.2014.08.06.10.26.29 for (version=TLSv1.1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 06 Aug 2014 10:26:29 -0700 (PDT) Received: from ruffy.mtv.corp.google.com (ruffy.mtv.corp.google.com [172.17.128.44]) by corp2gmr1-1.hot.corp.google.com (Postfix) with ESMTP id 0C27731C46A; Wed, 6 Aug 2014 10:26:28 -0700 (PDT) From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21474.25924.497358.887068@ruffy.mtv.corp.google.com> Date: Wed, 06 Aug 2014 17:26:00 -0000 To: Gary Benson Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 00/13] Include some headers in common-defs.h In-Reply-To: <1406644635-1011-1-git-send-email-gbenson@redhat.com> References: <1406644635-1011-1-git-send-email-gbenson@redhat.com> X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00108.txt.bz2 Gary Benson writes: > Hi all, > > This series builds on my "config.h rationalization" series that is > currently under review [1]. > > Each patch adds one #include line to common-defs.h and removes all > other inclusions of that file in all files that include either defs.h > or server.h. Patches 1-11 deal with files that are already included > by both defs.h and server.h; these patches don't really change > anything about the build. Patches 12 and 13 add gdb_assert.h and > string.h respectively. These are included by server.h but not by > defs.h, but both are included in hundreds of files so I think they > are good candidates for global inclusion. > > There are three more files that are included by both defs.h and > server.h that I have not dealt with in this series. errno.h and > alloca.h are both handled completely differently by defs.h and > server.h: moving these headers to common-defs.h should be done, but > will require merging the configury. The final file, print-utils.h, > is included indirectly by both defs.h and server.h but cannot be > merged without some of the "Common code cleanups" series [2]. That > needs some rewriting, so I'll add that to common-defs.h as part of > the next version of that series. > > Is this ok to commit? > > Thanks, > Gary > > -- > [1] https://sourceware.org/ml/gdb-patches/2014-07/msg00670.html > [2] https://sourceware.org/ml/gdb-patches/2014-07/msg00427.html LGTM