From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7575 invoked by alias); 6 Aug 2014 16:51:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7534 invoked by uid 89); 6 Aug 2014 16:51:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-oa0-f74.google.com Received: from mail-oa0-f74.google.com (HELO mail-oa0-f74.google.com) (209.85.219.74) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 06 Aug 2014 16:51:27 +0000 Received: by mail-oa0-f74.google.com with SMTP id eb12so520699oac.1 for ; Wed, 06 Aug 2014 09:51:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:cc:subject:in-reply-to :references; bh=E3pooD1MHqrATdTXbtO8Mg0o5uUFAlaaB5yS6PcL+tA=; b=CHl58NZPo94V/yhEZRuL5XUlsSDfO36tvqFObkjaoSLclAkQ5V5jGRmGWd1tmK8eFG NnCve1ecDPKKIq3WuZn0dzmm+OOUBVw7G4TSSAXlbN+Xb3WG1rJa7IKvedEHnbUtagDz 1wdZI7fjSQZm/rIOhmn2F5mlBwVyqE/HK/ydLp0rQMg+rvZzY1hoxnv+6ojOoOvidvNc D6+Zvk1qS/uh7jx3d4SFgFFOokIT0GGTE7vCchiPKTD/1ikUlgrtaNtcLJzSI5d1th7X /4wRwf9QUAdYCyyeSizAte+3TdM0DI4+bslcQXI5zgCyY/XK6mPDHISnVjkEFpgM8Bye 5wiw== X-Gm-Message-State: ALoCoQnBjvA6cKuTmhllJdQ04LBuLYMyQ+qYmDUK9LnxhffWURj5GT765iV4PqjM8yt3BXUb2a0b X-Received: by 10.42.16.69 with SMTP id o5mr7020225ica.17.1407343885033; Wed, 06 Aug 2014 09:51:25 -0700 (PDT) Received: from corp2gmr1-1.hot.corp.google.com (corp2gmr1-1.hot.corp.google.com [172.24.189.92]) by gmr-mx.google.com with ESMTPS id o69si97806yhp.6.2014.08.06.09.51.25 for (version=TLSv1.1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 06 Aug 2014 09:51:25 -0700 (PDT) Received: from ruffy.mtv.corp.google.com (ruffy.mtv.corp.google.com [172.17.128.44]) by corp2gmr1-1.hot.corp.google.com (Postfix) with ESMTP id 297B931C28F; Wed, 6 Aug 2014 09:51:24 -0700 (PDT) From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21474.23819.618023.581716@ruffy.mtv.corp.google.com> Date: Wed, 06 Aug 2014 16:51:00 -0000 To: Gary Benson Cc: gdb-patches@sourceware.org, Pedro Alves , Tom Tromey Subject: Re: [PATCH 03/11 v5] Move print-utils.h to common-defs.h In-Reply-To: <1406888377-25795-4-git-send-email-gbenson@redhat.com> References: <1406888377-25795-1-git-send-email-gbenson@redhat.com> <1406888377-25795-4-git-send-email-gbenson@redhat.com> X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00102.txt.bz2 Gary Benson writes: > This commit moves the inclusion of print-utils.h to common-defs.h > and removes all other inclusions. > > gdb/ > 2014-08-01 Gary Benson > > * common/common-defs.h: Include print-utils.h. > * utils.h: Do not include print-utils.h. > > gdb/gdbserver/ > 2014-08-01 Gary Benson > > * utils.h: Do not include print-utils.h. > --- > gdb/ChangeLog | 5 +++++ > gdb/common/common-defs.h | 1 + > gdb/gdbserver/ChangeLog | 4 ++++ > gdb/gdbserver/utils.h | 2 -- > gdb/utils.h | 1 - > 5 files changed, 10 insertions(+), 3 deletions(-) > > diff --git a/gdb/common/common-defs.h b/gdb/common/common-defs.h > index 5543e4c..66c0d21 100644 > --- a/gdb/common/common-defs.h > +++ b/gdb/common/common-defs.h > @@ -43,5 +43,6 @@ > #include "gdb_assert.h" > #include "errors.h" > #include "common-types.h" > +#include "print-utils.h" > > #endif /* COMMON_DEFS_H */ It's a bit odd to see common-defs.h include print-utils.h and not common-utils.h. I see it gets included by gdb_assert.h, but as a reader I'm still left with the question of wondering what's going on and wanting to spend time digging into it. I wonder if we can improve this somehow. [No need to work on that in this patch set though.]