From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8436 invoked by alias); 6 Aug 2014 16:20:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8424 invoked by uid 89); 6 Aug 2014 16:20:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qg0-f74.google.com Received: from mail-qg0-f74.google.com (HELO mail-qg0-f74.google.com) (209.85.192.74) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 06 Aug 2014 16:20:27 +0000 Received: by mail-qg0-f74.google.com with SMTP id z60so359889qgd.5 for ; Wed, 06 Aug 2014 09:20:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:cc:subject:in-reply-to :references; bh=R5gjng6IKdlefXTFUWMbXF4nHR6XKUcyN/VYB6V2WEc=; b=IokSFz2Jsmzkiethd6LKZo1eCWGDmPJElELwKBxQihGN+JVv8NdfWjL4S0J8I9NhlU whK9tOi2MLR50Bs4R8ZNrridY2izxen3uHjbA+XRq8p3Us7BDCaATZXaKPYbxYJXRGWc PHoFIjHe0fvjxmrq4Ho+QOLP8Jfylv4LRQGE9aWPHNyEDoK3UXzQpF9nJl2suN3OegOi rEFSTZ2WkuEp5hIp8rdBAGvGXQYtDYAQjK7sU58z181OYzpPJilQObHMMCc0shGiI12C udwYknFLh6rAaTIz8hlH4a7EOjJPvmgH9WXETEE3hB0rasbxS0kxXCkqhe3uCdQoSTy5 Qc+Q== X-Gm-Message-State: ALoCoQktB37HRsKZBw0xams7s0Of67T5Yf8OTORwJn1cpBm7vuHBOPuST/+C75oicC0wi7ZJkM3V X-Received: by 10.236.180.202 with SMTP id j50mr900830yhm.51.1407342024815; Wed, 06 Aug 2014 09:20:24 -0700 (PDT) Received: from corp2gmr1-1.hot.corp.google.com (corp2gmr1-1.hot.corp.google.com [172.24.189.92]) by gmr-mx.google.com with ESMTPS id v44si94037yhv.0.2014.08.06.09.20.24 for (version=TLSv1.1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 06 Aug 2014 09:20:24 -0700 (PDT) Received: from ruffy.mtv.corp.google.com (ruffy.mtv.corp.google.com [172.17.128.44]) by corp2gmr1-1.hot.corp.google.com (Postfix) with ESMTP id EAAC731C1DE; Wed, 6 Aug 2014 09:20:23 -0700 (PDT) From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21474.21959.405429.703789@ruffy.mtv.corp.google.com> Date: Wed, 06 Aug 2014 16:20:00 -0000 To: Gary Benson Cc: gdb-patches@sourceware.org, Pedro Alves , Tom Tromey Subject: Re: [PATCH 01/11 v5] Introduce common/errors.h In-Reply-To: <1406888377-25795-2-git-send-email-gbenson@redhat.com> References: <1406888377-25795-1-git-send-email-gbenson@redhat.com> <1406888377-25795-2-git-send-email-gbenson@redhat.com> X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00093.txt.bz2 Gary Benson writes: > This introduces common/errors.h. This holds some error- and > warning-related declarations that can be used by the code in common. > Clients of the "common" code must provide definitions for these > functions. > > gdb/ > 2014-08-01 Tom Tromey > Gary Benson > > * common/errors.h: New file. > * common/errors.c: Likewise. > * Makefile.in (HFILES_NO_SRCDIR): Add common/errors.h. > (COMMON_OBS): Add errors.o. > (errors.o): New rule. > * common/common-defs.h: Include errors.h. > * utils.h (perror_with_name, error, verror, warning, vwarning): > Don't declare. > * common/common-utils.h: (malloc_failure, internal_error): > Likewise. > > gdb/gdbserver/ > 2014-08-01 Tom Tromey > Gary Benson > > * Makefile.in (SFILES): Add common/errors.c. > (OBS): Add errors.o. > (IPA_OBS): Add errors-ipa.o. > (errors.o): New rule. > (errors-ipa.o): Likewise. > * utils.h (perror_with_name, error, warning): Don't declare. > * utils.c (warning): Renamed and rewritten as... > (vwarning): New function. > (error): Renamed and rewritten as... > (verror): New function. > (internal_error): Renamed and rewritten as... > (internal_verror): New function. > [...] > diff --git a/gdb/common/errors.c b/gdb/common/errors.c > new file mode 100644 > index 0000000..7d0bb6e > --- /dev/null > +++ b/gdb/common/errors.c > @@ -0,0 +1,61 @@ > +/* Error reporting facilities. > + > + Copyright (C) 1986-2014 Free Software Foundation, Inc. > + > + This file is part of GDB. > + > + This program is free software; you can redistribute it and/or modify > + it under the terms of the GNU General Public License as published by > + the Free Software Foundation; either version 3 of the License, or > + (at your option) any later version. > + > + This program is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + GNU General Public License for more details. > + > + You should have received a copy of the GNU General Public License > + along with this program. If not, see . */ > + > +#ifdef GDBSERVER > +#include "server.h" > +#else > +#include "defs.h" > +#endif > +#include "errors.h" Nit: The introductory email to this patch series didn't mention this instance of #ifdef GDBSERVER. Needed?