From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14836 invoked by alias); 24 Jul 2014 17:52:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14817 invoked by uid 89); 24 Jul 2014 17:52:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ie0-f202.google.com Received: from mail-ie0-f202.google.com (HELO mail-ie0-f202.google.com) (209.85.223.202) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 24 Jul 2014 17:52:20 +0000 Received: by mail-ie0-f202.google.com with SMTP id rl12so874558iec.1 for ; Thu, 24 Jul 2014 10:52:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:cc:subject:in-reply-to :references; bh=6+F5EXH9eP8GS9/7odGfwHQ4gxpqOoJ6cuVHg22pU2I=; b=GpBeNWMXQyjinP9uP4r3BKAlVmkibLL8nn7jv8zfk99QslWDTocvI2JkCnL7pp1NQD zfstM35THLYiVcUNP+w8dA1LPzQeFy+lMfgoJSh+jTb4m3bY5ejhkppayy1d92ARXsTo YCEQMoMjVlzvvJ/DC0n44cUsWpNbw62Tv58ZsjivYVSmXMAjwRhDK9yEELKNoJzc0S85 1vQoMSeTdOQS3kWrFAIrV3ZWu/FBrN7xfSZyomwQ5rtAVHu/9nB8ED+f+uUUKH/joczA 4KB+pw1VNzB87mkjtjtCeXK/PCEGHVaKGnG85zYV8pWAgW+vTP2boXjveShNfqe8PZRJ i+qg== X-Gm-Message-State: ALoCoQk9aWedqT0PhnVuFewKHUrsM644HE+DAUEsevg/OPLVsNAgDMFhvPcrBNbr5NMEq6lbkmdT X-Received: by 10.182.70.74 with SMTP id k10mr5207476obu.34.1406224338598; Thu, 24 Jul 2014 10:52:18 -0700 (PDT) Received: from corp2gmr1-2.hot.corp.google.com (corp2gmr1-2.hot.corp.google.com [172.24.189.93]) by gmr-mx.google.com with ESMTPS id v44si927659yhv.0.2014.07.24.10.52.18 for (version=TLSv1.1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 24 Jul 2014 10:52:18 -0700 (PDT) Received: from ruffy.mtv.corp.google.com (ruffy.mtv.corp.google.com [172.17.128.44]) by corp2gmr1-2.hot.corp.google.com (Postfix) with ESMTP id BB98D5A42F7; Thu, 24 Jul 2014 10:52:17 -0700 (PDT) From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21457.18385.59886.323894@ruffy.mtv.corp.google.com> Date: Thu, 24 Jul 2014 18:03:00 -0000 To: Pedro Alves Cc: Gary Benson , gdb-patches@sourceware.org, Tom Tromey Subject: Re: [PATCH 1/3 v4] Introduce common/errors.h In-Reply-To: <53D1053E.6030902@redhat.com> References: <1406206287-6817-1-git-send-email-gbenson@redhat.com> <1406206287-6817-2-git-send-email-gbenson@redhat.com> <53D1053E.6030902@redhat.com> X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00649.txt.bz2 Pedro Alves writes: > > + You should have received a copy of the GNU General Public License > > + along with this program. If not, see . */ > > + > > +#include "config.h" > > Sorry for the push back, but it's wrong to only include "config.h". > We need to include gnulib's config.h everywhere too. I think > the best is to add a central common header that handles that > detail first. OTOH, just including "config.h" is a real common thing to do across all packages. I can imagine this coming up again and again. IWBN if hacking on gdb didn't require special cases to standard programming paradigms wherever possible. Can we arrange for config.h to include gnulib's config.h? Or, another thought would be to have configure generate gdb-config.h (or some such) and then have src/gdb/config.h include both (and similarly for gdbserver - haven't looked at the details though).