From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19911 invoked by alias); 14 Jul 2014 18:47:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19890 invoked by uid 89); 14 Jul 2014 18:47:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pd0-f202.google.com Received: from mail-pd0-f202.google.com (HELO mail-pd0-f202.google.com) (209.85.192.202) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 14 Jul 2014 18:47:51 +0000 Received: by mail-pd0-f202.google.com with SMTP id r10so982620pdi.3 for ; Mon, 14 Jul 2014 11:47:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:cc:subject:in-reply-to :references; bh=Ypbvq5+cg6yGPjlmghZS+Aevw/wDELUt0gEI9FPxgc0=; b=m6I+kFgmFx4J7JpGAGF0A4XtyXh4wi12Bj8aOkVI9zOx0MYY61A7Qz5ky+GOPotfmR x1NhoE9Pj10kpaw2U21RpkMNUsS06yqQWcZ8C+o52qsy8hTw15PeEszPd2CF3V8kFD1Q y+esxjzgI0LXi+G8MOVTwdJSK8Q226Qhm0JaGdzCbzNrVroONtv1EfLoQbvyMIF8Ki81 BS+Y5XfEUrWmFL9fzHPN4dO1J2w/QBTRnGS9bBhuUf1aqG80SNGfolk7Zn2cR+JR0+8B Y/v7rFP0GdeumZ7AmmB2YKb2VVRvl+6ampvK+hzsBWu4DccjSbRi+jlT1aNdJG9w50Lz o3QQ== X-Gm-Message-State: ALoCoQkMOWZ2A7m3Vihr4uFQYFZjMz4epblGYYVrmIF8Mm8P9y2KbVep36kbWjqi8+gXoHjO3L1p X-Received: by 10.66.65.202 with SMTP id z10mr8487457pas.45.1405363670133; Mon, 14 Jul 2014 11:47:50 -0700 (PDT) Received: from corp2gmr1-1.hot.corp.google.com (corp2gmr1-1.hot.corp.google.com [172.24.189.92]) by gmr-mx.google.com with ESMTPS id j43si797245yhh.5.2014.07.14.11.47.50 for (version=TLSv1.1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 14 Jul 2014 11:47:50 -0700 (PDT) Received: from ruffy.mtv.corp.google.com (ruffy.mtv.corp.google.com [172.17.128.44]) by corp2gmr1-1.hot.corp.google.com (Postfix) with ESMTP id 8645F31C54E; Mon, 14 Jul 2014 11:47:49 -0700 (PDT) From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21444.9684.974497.695609@ruffy.mtv.corp.google.com> Date: Mon, 14 Jul 2014 18:49:00 -0000 To: Gary Benson Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 06/15] Remove simple GDBSERVER uses from common, nat and target In-Reply-To: <1404902255-11101-7-git-send-email-gbenson@redhat.com> References: <1404902255-11101-1-git-send-email-gbenson@redhat.com> <1404902255-11101-7-git-send-email-gbenson@redhat.com> X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00348.txt.bz2 Gary Benson writes: > This removes various simple GDBSERVER uses from common, nat and > target. The simple uses are just cases where the code includes defs.h > or server.h depending on GDBSERVER. Instead, now the files include > the headers that they require. Unfortunately we still need to check > GDBSERVER for some files to decide which gnulib config header to > import, but this is a step in the right direction. > > gdb/ > 2014-07-09 Tom Tromey > Gary Benson > > * common/buffer.c: Don't include server.h or defs.h; update > includes. > * common/common-utils.c: Don't include server.h or defs.h; update > includes. > * common/filestuff.c: Don't include server.h or defs.h; update > includes. > * common/filestuff.h: Include stdio.h. > * common/format.c: Don't include server.h or defs.h; update > includes. > * common/gdb_vecs.c: Don't include server.h or defs.h; update > includes. > * common/print-utils.c: Don't include server.h or defs.h; update > includes. > * common/rsp-low.c: Don't include server.h or defs.h; update > includes. > * common/signals.c: Don't include server.h or defs.h; update > includes. > * common/vec.c: Don't include server.h or defs.h; update includes. > * common/xml-utils.c: Don't include server.h or defs.h; update > includes. > * nat/linux-osdata.c: Don't include server.h or defs.h; update > includes. > * nat/linux-procfs.c: Don't include server.h or defs.h; update > includes. > * nat/linux-ptrace.c: Don't include server.h or defs.h; update > includes. > * nat/mips-linux-watch.h: Don't include server.h or defs.h; update > includes. > * target/waitstatus.c: Don't include server.h or defs.h; update > includes. LGTM, one nit: How about #include "config.h" instead of #include ?