From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5683 invoked by alias); 14 Jul 2014 19:17:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5653 invoked by uid 89); 14 Jul 2014 19:17:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-yh0-f74.google.com Received: from mail-yh0-f74.google.com (HELO mail-yh0-f74.google.com) (209.85.213.74) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 14 Jul 2014 19:17:27 +0000 Received: by mail-yh0-f74.google.com with SMTP id b6so792088yha.1 for ; Mon, 14 Jul 2014 12:17:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:cc:subject:in-reply-to :references; bh=rwKsCxpoSqA4ZeUTwtF4Vgyuypp5uhgwbNqc7HbG3EE=; b=PFjXElzmH+VaZIlwGucPdMpPVAc+HtzehIVvEe1ogFB8kBeDkgtI+iKf4IcRFbLjDa 9dCtesKVDlZBZP7m02Ey+Wdcp5H0YUnp+t+v48+kxTJxFdznDSeTKWgsXBEALyrsfMwd abveqpRplYPkpBC90/GWON/EpnePi3YxqHhWYObaSmmqz3//91dTOXFN5MQIH0/l0hwn o60Lo0CtMg2wzmmWRLE0SlE3tkzJczgGhimnULjB/BXbCZiqBQL7sbvTTHd9Ezx0Xh2N T9lc5LfZ7tV/+bdibYWvze628ELbU47ude9K6IPmz7C0++7IBdvsKLTxa0p+MLUAuXS7 fOYQ== X-Gm-Message-State: ALoCoQnb9YkAWguyWohefORfP9R1l2V8AdDVHHFAb5OKWJXcsqBj9MEVrYfho4FNW9Nez69gZXVr X-Received: by 10.236.168.101 with SMTP id j65mr7554923yhl.30.1405365445732; Mon, 14 Jul 2014 12:17:25 -0700 (PDT) Received: from corp2gmr1-1.hot.corp.google.com (corp2gmr1-1.hot.corp.google.com [172.24.189.92]) by gmr-mx.google.com with ESMTPS id c50si802233yhl.7.2014.07.14.12.17.25 for (version=TLSv1.1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 14 Jul 2014 12:17:25 -0700 (PDT) Received: from ruffy.mtv.corp.google.com (ruffy.mtv.corp.google.com [172.17.128.44]) by corp2gmr1-1.hot.corp.google.com (Postfix) with ESMTP id 1F15B31C3AB; Mon, 14 Jul 2014 12:17:24 -0700 (PDT) From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21444.11460.553754.490153@ruffy.mtv.corp.google.com> Date: Mon, 14 Jul 2014 19:35:00 -0000 To: Gary Benson Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 13/15] Finally remove GDBSERVER (mostly) from agent.c In-Reply-To: <1404902255-11101-14-git-send-email-gbenson@redhat.com> References: <1404902255-11101-1-git-send-email-gbenson@redhat.com> <1404902255-11101-14-git-send-email-gbenson@redhat.com> X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00354.txt.bz2 Gary Benson writes: > This reduces the use of the GDBSERVER define in agent.c to deciding > which gnulib header to include. > > gdb/ > 2014-07-09 Tom Tromey > Gary Benson > > * common/agent.c: Don't include defs.h or server.h. LGTM. Might want to expand on the changelog entry to be like 06/15(?). E.g., * common/buffer.c: Don't include server.h or defs.h; update includes.