From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11494 invoked by alias); 14 Jul 2014 18:59:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11457 invoked by uid 89); 14 Jul 2014 18:59:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS,URIBL_BLACK autolearn=no version=3.3.2 X-HELO: mail-oa0-f73.google.com Received: from mail-oa0-f73.google.com (HELO mail-oa0-f73.google.com) (209.85.219.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 14 Jul 2014 18:59:48 +0000 Received: by mail-oa0-f73.google.com with SMTP id g18so944219oah.2 for ; Mon, 14 Jul 2014 11:59:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:cc:subject:in-reply-to :references; bh=N01su7ibHJMlBOHlg/bpLEeR/AvSRlGohy9/3/IRhfk=; b=In/huBFyM8Ab/XxJMaClOvuQd+JDjBgYkFI/zrDpSIHh0aDQAkdgAfsUnugBgDsC5k HnyU1jZan6iTt7/zeR9tQ5IEtHjbHHxJpA2OSg9S23lgS06K6mWQ0EUH00ud6zUQzBkZ FTBlp5sji1vCnNXxDkKf6e+WIwE0l7mqPpsFUpkTHGkJe6dn2/RJTHAkdkDiy2/mIneP uFrtQ7glIfysA1Zq3D0fAkTl0zaIgPihpXO635FHa/svAQUTqnk/5cU5dtMbS9aFdgkF e28nyrE+wTh7SNE2iq59p4KZk/X8t+sB1idQtGMhH898OOqj3bqn3E+yhz2L3Vx/bW/b X3yA== X-Gm-Message-State: ALoCoQm05cwbeEdm5VWQybSBhTDkhO9G/kmTkrXXahrE0qOcUpdJNipMz22TvGX77jrg3V/FXCCe X-Received: by 10.182.45.161 with SMTP id o1mr8675995obm.2.1405364386447; Mon, 14 Jul 2014 11:59:46 -0700 (PDT) Received: from corp2gmr1-2.hot.corp.google.com (corp2gmr1-2.hot.corp.google.com [172.24.189.93]) by gmr-mx.google.com with ESMTPS id c50si798377yhl.7.2014.07.14.11.59.46 for (version=TLSv1.1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 14 Jul 2014 11:59:46 -0700 (PDT) Received: from ruffy.mtv.corp.google.com (ruffy.mtv.corp.google.com [172.17.128.44]) by corp2gmr1-2.hot.corp.google.com (Postfix) with ESMTP id E4C015A4606; Mon, 14 Jul 2014 11:59:45 -0700 (PDT) From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21444.10401.389963.415776@ruffy.mtv.corp.google.com> Date: Mon, 14 Jul 2014 19:01:00 -0000 To: Gary Benson Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 09/15] Mostly remove GDBSERVER from linux-waitpid.c In-Reply-To: <1404902255-11101-10-git-send-email-gbenson@redhat.com> References: <1404902255-11101-1-git-send-email-gbenson@redhat.com> <1404902255-11101-10-git-send-email-gbenson@redhat.com> X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00351.txt.bz2 Gary Benson writes: > This commit mostly removes the use of GDBSERVER from > nat/linux-waitpid.c. A use remains for some debugging > code that I will remove when the Linux thread_db code > is refactored. > > gdb/ > 2014-07-09 Gary Benson > > * configure.ac [AC_CHECK_HEADERS] : New check. > * configure: Regenerate. > * config.in: Likewise. > * nat/linux-waitpid.c: Don't include server.h or defs.h. > (linux_debug) [debug_threads]: New declaration. gdb includes errno.h unconditionally, so the test is for some gdbserver configs (right?). It's going to be confusing to keep all the unconditional inclusions of errno.h and yet seeing it tested for in configure.ac. It would be good to document why things are the way they are. E.g., add a comment to configure.ac or some such saying the test is needed by common code used by gdb and gdbserver. OTOH, I see there is gnulib/import/errno.in.h. Can we solve this with gnulib and thus make errno.h unconditionally includable everywhere?