From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13973 invoked by alias); 11 Jul 2014 19:30:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13954 invoked by uid 89); 11 Jul 2014 19:30:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-oa0-f74.google.com Received: from mail-oa0-f74.google.com (HELO mail-oa0-f74.google.com) (209.85.219.74) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 11 Jul 2014 19:30:39 +0000 Received: by mail-oa0-f74.google.com with SMTP id eb12so129055oac.3 for ; Fri, 11 Jul 2014 12:30:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:cc:subject:in-reply-to :references; bh=6LvWuvJ2ZwY1O/Xc0FjcWVpfA3ItnWx/WyZAS5ZX1pI=; b=H/U2s/46R5bhap51IDcsKAByfYlJPlJY6nGWzznspGMd2N6UR0W8zSFP9vTLkThSQ5 xOgA5p2ofP7EdrzdbIP+RvkEgj0lFqqK5H4yThdQJKpdG53NUNnG+i2uD0X9jUyTnSmW HHAcmUwj0qP0uLVO974duoj+CSgY3cG7NqXdZdlIXoHSGE4TMh944kZH4ji/s86OAx+k XktxT6hHw2Hihmzpu3pyVeb/Wndokglgs2QTzoqhFqFgmF+3kFZ0+JqghUOeVBFDGaLI G3Y+F4GaPZAgjIX6HlQ0jPwd3C0l3dkyhXsuw94ET6nxEoulHQGOO2LT4pBvRucs33+L 449Q== X-Gm-Message-State: ALoCoQlf6eQhYj3miVtdUgkKktxm/GihCUPHkLa03+BkBF+b3ZxKFQ+yojeHGxax/xuN7SArZGaN X-Received: by 10.182.28.5 with SMTP id x5mr443917obg.44.1405107037617; Fri, 11 Jul 2014 12:30:37 -0700 (PDT) Received: from corp2gmr1-1.hot.corp.google.com (corp2gmr1-1.hot.corp.google.com [172.24.189.92]) by gmr-mx.google.com with ESMTPS id o69si238148yhp.6.2014.07.11.12.30.37 for (version=TLSv1.1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 11 Jul 2014 12:30:37 -0700 (PDT) Received: from ruffy.mtv.corp.google.com (ruffy.mtv.corp.google.com [172.17.128.44]) by corp2gmr1-1.hot.corp.google.com (Postfix) with ESMTP id 1A0DD31C321; Fri, 11 Jul 2014 12:30:36 -0700 (PDT) From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21440.15196.562287.394755@ruffy.mtv.corp.google.com> Date: Fri, 11 Jul 2014 19:34:00 -0000 To: Gary Benson Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 03/15] Make gdbserver CORE_ADDR unsigned In-Reply-To: <1404902255-11101-4-git-send-email-gbenson@redhat.com> References: <1404902255-11101-1-git-send-email-gbenson@redhat.com> <1404902255-11101-4-git-send-email-gbenson@redhat.com> X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00291.txt.bz2 Gary Benson writes: > gdbserver defines CORE_ADDR to be signed. This seems erroneous to > me; and furthermore likely to cause problems in common/, as it is > different from gdb's definition. > > gdb/gdbserver/ > 2014-07-09 Tom Tromey > > * defs.h (CORE_ADDR): Now unsigned. > --- > gdb/gdbserver/ChangeLog | 4 ++++ > gdb/gdbserver/server.h | 2 +- > 2 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/gdb/gdbserver/server.h b/gdb/gdbserver/server.h > index 6eb1a16..2d55513 100644 > --- a/gdb/gdbserver/server.h > +++ b/gdb/gdbserver/server.h > @@ -87,7 +87,7 @@ typedef unsigned char gdb_byte; > > /* FIXME: This should probably be autoconf'd for. It's an integer type at > least the size of a (void *). */ > -typedef long long CORE_ADDR; > +typedef unsigned long long CORE_ADDR; > > typedef long long LONGEST; > typedef unsigned long long ULONGEST; > -- > 1.7.1 > LGTM, modulo file name spelled wrong in changelog entry.