Re: [PATCH 29/40] Simplify completion_list_add_name | remove sym_text / sym_text_len

Keith Seitz
2017-08-08T20:59:23Z

On 06/02/2017 05:22 AM, Pedro Alves wrote:
>
> gdb/ChangeLog:
> yyyy-mm-dd Pedro Alves <palves@redhat.com>
>
> * ada-lang.c (ada_make_symbol_completion_list): Remove text and
> text_len locals and don't pass them down.
> * symtab.c (completion_list_add_name): Remove
> sym_text/sym_text_len parameters and adjust.
> (completion_list_add_symbol, completion_list_add_msymbol)
> (completion_list_objc_symbol, completion_list_add_fields)
> (add_symtab_completions): Likewise.
> (default_collect_symbol_completion_matches_break_on)
> (collect_file_symbol_completion_matches): Remove sym_text_len
> local and don't pass it down.
> * symtab.h (completion_list_add_name): Remove
> sym_text/sym_text_len parameters.

LGTM

Keith