Re: [PATCH 09/40] Rename make_symbol_completion_list_fn -> symbol_completer

Pedro Alves
2017-07-17T11:00:53Z

On 07/13/2017 09:46 PM, Keith Seitz wrote:
> On 06/02/2017 05:22 AM, Pedro Alves wrote:
>> "make_symbol_completion_list_fn" is odly named when you look at a list
>> of "standard" completers, like the Python/Guild completer lists
>> adjusted by this patch. Rename / move it to completers.h/c, for
>> consistency.
>
> Oh, man, I totally agree. make_symbol_completion_list_fn sounds more like a typedef name!
>
> And who could possibly complain about shortening symtab.[ch]. Those files are already a little bloated with non-symtab stuff.
>
> I see no issues with this patch.

Thanks guys. I pushed this one in.

--
Pedro Alves