From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7520 invoked by alias); 24 Feb 2014 23:37:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7508 invoked by uid 89); 24 Feb 2014 23:37:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ob0-f201.google.com Received: from mail-ob0-f201.google.com (HELO mail-ob0-f201.google.com) (209.85.214.201) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 24 Feb 2014 23:37:56 +0000 Received: by mail-ob0-f201.google.com with SMTP id wp4so502709obc.4 for ; Mon, 24 Feb 2014 15:37:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:subject:in-reply-to :references; bh=qk+c8cCIYYtFlZDV8mI/SxeK1L7p68ONn01/RcjcjL0=; b=SGOZFtgziqJlA2Pcu9JfAB6TcJECncefnkwyzjiAaahvN9E908gU+mSMFDMGG7nj5z VR3O5D831i1ZKw7BxQqWGXkxBxfJreFZOf1TxrY1KDv9C2uld2+DZmcJRo/W2179E4m8 3Y5W15fOeb93MPAG8mhg0G1EGBuUddIZx8WgV4fzvYV29qk7c76bBIsiNtv26Jmkl3XE ZHPlyvS4xa7DVKkgj9uHGCzebCJTFIbIV7gkkJCl8VYV8LqN7KnfHmSfDJpyB1j/28y0 1vKCelQ2OU98LmDyeNzfgZyJy1Xpymx9YnZLedtZHM5E4AyN5j9LAW8SimrhlrCruoGq 2F4A== X-Gm-Message-State: ALoCoQn/SvYOB8xROeBjpOLwBHF77YORJHyq8IvwUW94D6XAqw7xzgTgVK0I7dauwOkQBRtv81u+9DVKRMZgEwkw3n3+4j96bOW1g9zCk+V7JANSPhwugc2+Vxk/8MSkNh4wtZO2QPcgmvB963Tz63SnCliRgc1LbpL0Oj40j68uuammJkLa70uHMiECPSqk14TaPs9Uk4/8tqH+6uEuQpuAA73ifT4FiNma2oMdwLzYCCv63YYqitI= X-Received: by 10.182.216.200 with SMTP id os8mr10389283obc.0.1393285075008; Mon, 24 Feb 2014 15:37:55 -0800 (PST) Received: from corp2gmr1-1.hot.corp.google.com (corp2gmr1-1.hot.corp.google.com [172.24.189.92]) by gmr-mx.google.com with ESMTPS id x29si121923yha.0.2014.02.24.15.37.54 for (version=TLSv1.1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 24 Feb 2014 15:37:54 -0800 (PST) Received: from ruffy.mtv.corp.google.com (ruffy.mtv.corp.google.com [172.17.128.44]) by corp2gmr1-1.hot.corp.google.com (Postfix) with ESMTP id 98B4031C27E for ; Mon, 24 Feb 2014 15:37:54 -0800 (PST) From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21259.55250.80049.22334@ruffy.mtv.corp.google.com> Date: Mon, 24 Feb 2014 23:37:00 -0000 To: gdb-patches@sourceware.org Subject: Re: [PATCH] Delete "Loaded symbols for ..." message in solib.c In-Reply-To: References: X-IsSubscribed: yes X-SW-Source: 2014-02/txt/msg00742.txt.bz2 Doug Evans writes: > Hi. > > gdb currently prints two messages when loading symbols for shared libraries. > E.g., > > Reading symbols from /usr/lib64/libm.so.6...(no debugging symbols found)...done. > Loaded symbols for /usr/lib64/libm.so.6 > > The second one is redundant. > > Regression tested on amd64-linux. > > 2014-02-24 Doug Evans > > * solib.c (solib_read_symbols): Delete "Loaded symbols for ..." > message, it is redundant with "Reading symbols from ..." message. > > diff --git a/gdb/solib.c b/gdb/solib.c > index 3350bfd..8fd4f60 100644 > --- a/gdb/solib.c > +++ b/gdb/solib.c > @@ -649,11 +649,7 @@ solib_read_symbols (struct so_list *so, int flags) > " library symbols for %s:\n"), > so->so_name); > else > - { > - if (from_tty || info_verbose) > - printf_unfiltered (_("Loaded symbols for %s\n"), so->so_name); > - so->symbols_loaded = 1; > - } > + so->symbols_loaded = 1; > return 1; > } > Err, one more time ... I debated whether to alter this comment: /* Read in symbols for shared object SO. If SYMFILE_VERBOSE is set in FLAGS, be chatty about it. Return non-zero if any symbols were actually loaded. */ It's still correct, and provides useful information to the reader, though the actual implementation of "be chatty about it" is done later and not inside this function itself. 2014-02-24 Doug Evans * solib.c (solib_read_symbols): Delete "Loaded symbols for ..." message, it is redundant with "Reading symbols from ..." message. diff --git a/gdb/solib.c b/gdb/solib.c index 3350bfd..c9bbc0a 100644 --- a/gdb/solib.c +++ b/gdb/solib.c @@ -604,8 +604,6 @@ master_so_list (void) int solib_read_symbols (struct so_list *so, int flags) { - const int from_tty = flags & SYMFILE_VERBOSE; - if (so->symbols_loaded) { /* If needed, we've already warned in our caller. */ @@ -649,11 +647,7 @@ solib_read_symbols (struct so_list *so, int flags) " library symbols for %s:\n"), so->so_name); else - { - if (from_tty || info_verbose) - printf_unfiltered (_("Loaded symbols for %s\n"), so->so_name); - so->symbols_loaded = 1; - } + so->symbols_loaded = 1; return 1; }