From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4300 invoked by alias); 20 Feb 2014 21:19:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4280 invoked by uid 89); 20 Feb 2014 21:19:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f74.google.com Received: from mail-pa0-f74.google.com (HELO mail-pa0-f74.google.com) (209.85.220.74) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 20 Feb 2014 21:19:33 +0000 Received: by mail-pa0-f74.google.com with SMTP id fa1so385637pad.3 for ; Thu, 20 Feb 2014 13:19:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:subject:in-reply-to :references; bh=J555n/WV98efhD0PwdQGgR9vfkFnr9m+2V1zHTrfeXU=; b=Hhp9EeOod3F59CgYhgSpxOMwTDqdo9yr0s4ytgYLAHSctPd964r2R3fKjDsE0FspQW EzeIEbgeLFMlQt0vAlccdg6BpqIFmNBCRXEMLP7L3TOxWQXvfUbCpA+g1dsIYVbQejDb rNrsvu6nyEZ3BftBNdxRMrCB8PttujOVxZPvZwwNSwGRmJiTZk6MSvRSvV43T28CZOXI rbgzrAQCZJtCG2HxGAukdtniJJ91pnf7ezv3ZUfWO1bI8uR+iGBHw1PIesX/reCbsFaE eOqK+AyIipGa8R+BVyvO8x4OFgrPMTdBfUvXLSoS6YmiwnPKdR4TifHdCvbVIo0IPHlK B+gw== X-Gm-Message-State: ALoCoQn94yyHvUmpho9w/wfJAuZjjI/LGCJeGljXHBawec4SKRvQeo4zyBmvpWIpiHC+lI8RjaUYI/8a51tFya8cvkGsQ505ERJzPe9dH0aOnFiM3xPE6ocw/ILhhjnI02MbUSr1WzcxnYmCwY3JkmPqyGxcw9JVs1iU9b1u0VLfAOul760m69Bw+t5fU5Vg8YWH1naorCKOO9dC4Od8AHgDxZbRb5CACg6sGZeGSUVfs5Uu3pnKYek= X-Received: by 10.66.26.132 with SMTP id l4mr1793286pag.2.1392931171636; Thu, 20 Feb 2014 13:19:31 -0800 (PST) Received: from corp2gmr1-2.hot.corp.google.com (corp2gmr1-2.hot.corp.google.com [172.24.189.93]) by gmr-mx.google.com with ESMTPS id k45si335004yhn.4.2014.02.20.13.19.31 for (version=TLSv1.1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 20 Feb 2014 13:19:31 -0800 (PST) Received: from ruffy.mtv.corp.google.com (ruffy.mtv.corp.google.com [172.17.128.44]) by corp2gmr1-2.hot.corp.google.com (Postfix) with ESMTP id 345035A4129 for ; Thu, 20 Feb 2014 13:19:31 -0800 (PST) From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21254.29024.423597.260936@ruffy.mtv.corp.google.com> Date: Thu, 20 Feb 2014 21:19:00 -0000 To: gdb-patches@sourceware.org Subject: Re: [PATCH v2 2/3] remove all_lwps from gdbserver: use list api In-Reply-To: References: X-IsSubscribed: yes X-SW-Source: 2014-02/txt/msg00660.txt.bz2 Doug Evans writes: > Hi. > This patch provides missing API routines where necessary, > and removes all references to list implementation details > outside of inferiors.c. This patch fixes a buglet that was introduced. Committed. 2014-02-20 Doug Evans * inferiors.c (get_first_inferior): Fix buglet. diff --git a/gdb/gdbserver/inferiors.c b/gdb/gdbserver/inferiors.c index f83ee22..8c1375f 100644 --- a/gdb/gdbserver/inferiors.c +++ b/gdb/gdbserver/inferiors.c @@ -178,8 +178,8 @@ remove_thread (struct thread_info *thread) struct inferior_list_entry * get_first_inferior (struct inferior_list *list) { - if (all_threads.head != NULL) - return all_threads.head; + if (list->head != NULL) + return list->head; return NULL; }