From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9786 invoked by alias); 16 Jan 2014 23:28:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9774 invoked by uid 89); 16 Jan 2014 23:28:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qa0-f74.google.com Received: from mail-qa0-f74.google.com (HELO mail-qa0-f74.google.com) (209.85.216.74) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 16 Jan 2014 23:28:12 +0000 Received: by mail-qa0-f74.google.com with SMTP id cm18so304558qab.1 for ; Thu, 16 Jan 2014 15:28:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:cc:subject:in-reply-to :references; bh=iRTRC1rrM8A+hDysMa42jZPMhTDxi/Hclvh0ns44Ja0=; b=l6djd/zHmNaPQ/JRX17/obBR5ceFLLSJemeQXGi1pE+DcUiPdAy1W6PLUW02SAH3qh YTcJMsXlpCFU5rD8fQb069td3FHvYLX/lsogxsj2/ZLk4KDeNb3dxTGVplBIHrGOk54s faxw8lz9q4bFu3DFbyLjh0rA3h2bvDMZsrX/bkoLYu+Mfw0QV9eMGcdBbuMk/jrbSnil 3tmQaIwJkOFwtKtmmLag+wD1FbbNtwNmC6GqNZRcOt+6DQni42BBSJa3i7TZdbly3w07 klsejXI78wrl3D52nMLS6/K2c83GG8/SN+3L0zn21UL75eZ8J4Of8XHHfLD9PtRD/vOH ZMQg== X-Gm-Message-State: ALoCoQmRp9U3mP8HL+lTifXlmIOWg3LM0ZtZf4yjLSaTiZp803snicKSOftiwkZ9KktW/txWftSnJzNFDfAyidGu+oUcM56p4AuQoOvatEfcgaz8af1uaFMU86An8ZBENsZJBjBf/rLGN1YMZcImycXs9mpB/y6YZwq9aKMQBeDyFvXwvUsdv7+mVthQJ25nmeMk512g/huocPN75ZtJdNDQOXnb/cMDpQ== X-Received: by 10.59.12.105 with SMTP id ep9mr4804009ved.9.1389914889929; Thu, 16 Jan 2014 15:28:09 -0800 (PST) Received: from corp2gmr1-2.hot.corp.google.com (corp2gmr1-2.hot.corp.google.com [172.24.189.93]) by gmr-mx.google.com with ESMTPS id o30si2969843yhn.1.2014.01.16.15.28.09 for (version=TLSv1.1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 16 Jan 2014 15:28:09 -0800 (PST) Received: from ruffy.mtv.corp.google.com (ruffy.mtv.corp.google.com [172.17.128.44]) by corp2gmr1-2.hot.corp.google.com (Postfix) with ESMTP id 3E2FD5A42EB; Thu, 16 Jan 2014 15:28:09 -0800 (PST) From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21208.27400.695984.88504@ruffy.mtv.corp.google.com> Date: Thu, 16 Jan 2014 23:28:00 -0000 To: Pedro Alves , Yao Qi cc: gdb-patches Subject: [PATCH 0/3] Add debug_printf and timestamps to gdbserver In-Reply-To: <52D82AD5.7000306@redhat.com> References: <52B1842F.5020401@redhat.com> <21205.55987.69477.892571@ruffy.mtv.corp.google.com> <52D81569.3080006@redhat.com> <52D82AD5.7000306@redhat.com> X-IsSubscribed: yes X-SW-Source: 2014-01/txt/msg00657.txt.bz2 Pedro Alves writes: > On 01/16/2014 06:43 PM, Doug Evans wrote: > > On Thu, Jan 16, 2014 at 9:22 AM, Pedro Alves wrote: > > > A counter-proposal is that no information is lost given that if PROG > > isn't present you know it's gdbserver, and it makes the debugging > > output consistent with the rest of gdbserver. > > Otherwise "Consistency Is Good" is going to make me want to prepend > > PROG to all gdbserver output, which I don't have a problem with, but > > thought I'd double check. > > OK, I'll concede. Let's try going without. > > >>> diff --git a/gdb/gdbserver/utils.c b/gdb/gdbserver/utils.c > >>> index eff4499..1ce5512 100644 > >>> --- a/gdb/gdbserver/utils.c > >>> +++ b/gdb/gdbserver/utils.c > >> > >> Could this new debug support code be put in a new file > >> instead? E.g., gdbserver/debug.c ? > > > > It's a pretty-small file, and utils.c is kind of our collective > > kitchen sink for such things. > > Well, I/we've been trying to stop kitchen sinks. It makes > turning things into libraries much easier. See the "common" > project wiki page, for example. Things grow into kitchen sinks > little by little. Before you know it, the beast is huge. > > > I have no preference, just double checking that that's what you want. > > It is. > > >> It'd be nice if this and gdb_assert.h's version of the same were > >> shared. That is, e.g., put this in common/common-utils.h instead, > >> and make gdb_assert.h define ASSERT_FUNCTION as FUNCTION_NAME > >> (or eliminate ASSERT_FUNCTION entirely). Are you planning on > >> doing it? > > > > Done in v2. > > Thanks. v2 is now split into three parts: 1/3 - move ASSERT_FUNCTION to FUNCTION_NAME in common-utils.h 2/3 - create new function delim_string_to_char_ptr_vec_append in gdb_vecs.c 3/3 - the actual debug_printf patch I went with --debug[=timestamp] as the option naming.