From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Eli Zaretskii" To: mir@sunchorus.France.Sun.COM Cc: pedwards@disaster.jaj.com, gdb-patches@sources.redhat.com Subject: Re: PATCH doc/refcard.tex Date: Tue, 26 Dec 2000 08:50:00 -0000 Message-id: <2110-Tue26Dec2000184743+0200-eliz@is.elta.co.il> References: <200012261042.LAA19117@sunchorus.France.Sun.COM> X-SW-Source: 2000-12/msg00258.html > From: Adam Mirowski > Date: Tue, 26 Dec 2000 11:41:10 +0-100 > > > >This works for me with Bash. Hmm. Does it work if you replace > >"$(REFEDITS)" with $$REFEDITS ? (You might need to "export REFEDITS" > >somewhere in the Makefile.) > > There are no quotes around the refedits variable, that > is the problem. Does it work in /bin/sh if you add an extra pair of quotes? If that helps, I will commit the change. >From pedwards@disaster.jaj.com Tue Dec 26 11:56:00 2000 From: Phil Edwards To: Eli Zaretskii Cc: mir@sunchorus.France.Sun.COM, gdb-patches@sources.redhat.com Subject: Re: PATCH doc/refcard.tex Date: Tue, 26 Dec 2000 11:56:00 -0000 Message-id: <20001226150540.A7688@disaster.jaj.com> References: <200012261042.LAA19117@sunchorus.France.Sun.COM> <2110-Tue26Dec2000184743+0200-eliz@is.elta.co.il> X-SW-Source: 2000-12/msg00259.html Content-length: 1024 On Tue, Dec 26, 2000 at 06:47:44PM +0200, Eli Zaretskii wrote: > > From: Adam Mirowski > > Date: Tue, 26 Dec 2000 11:41:10 +0-100 > > > > > >This works for me with Bash. Hmm. Does it work if you replace > > >"$(REFEDITS)" with $$REFEDITS ? (You might need to "export REFEDITS" > > >somewhere in the Makefile.) Even using the latest version of bash 2.x that failed for me. And since REFEDITS is a makefile variable, it should be replaced before the shell is called; exporting isn't necessary. > > There are no quotes around the refedits variable, that > > is the problem. > > Does it work in /bin/sh if you add an extra pair of quotes? If that > helps, I will commit the change. It helps for me, but I don't know what that will do to other shells. Phil -- pedwards at disaster dot jaj dot com | pme at sources dot redhat dot com devphil at several other less interesting addresses in various dot domains The gods do not protect fools. Fools are protected by more capable fools. >From eliz@delorie.com Wed Dec 27 00:25:00 2000 From: Eli Zaretskii To: mir@sunchorus.France.Sun.COM Cc: pedwards@disaster.jaj.com, gdb-patches@sources.redhat.com Subject: Re: PATCH doc/refcard.tex Date: Wed, 27 Dec 2000 00:25:00 -0000 Message-id: <200012270825.DAA02213@indy.delorie.com> References: <200012261042.LAA19117@sunchorus.France.Sun.COM> X-SW-Source: 2000-12/msg00260.html Content-length: 781 > > There are no quotes around the refedits variable, that > is the problem. Sorry, I came to a conclusion that I don't understand the problem. Here's the relevant fragment from doc/Makefile.in: # GDB QUICK REFERENCE (dvi output) refcard.dvi : refcard.tex $(REFEDITS) if [ -z "$(REFEDITS)" ]; then \ cp $(srcdir)/refcard.tex sedref.tex ; \ else \ echo > tmp.sed ; \ for f in "$(REFEDITS)" ; do \ cat $(srcdir)/$$f >>tmp.sed ; done ; \ sed -f tmp.sed $(srcdir)/refcard.tex >sedref.tex ; \ fi $(SET_TEXINPUTS) $(TEX) sedref.tex mv sedref.dvi refcard.dvi rm -f sedref.log sedref.tex tmp.sed As you see, $(REFEDITS) _is_ wrapped in quotes, and the shell should see ``for f in "" ; do''. Am I missing something? >From eliz@delorie.com Wed Dec 27 00:26:00 2000 From: Eli Zaretskii To: pedwards@disaster.jaj.com Cc: mir@sunchorus.France.Sun.COM, gdb-patches@sources.redhat.com Subject: Re: PATCH doc/refcard.tex Date: Wed, 27 Dec 2000 00:26:00 -0000 Message-id: <200012270826.DAA02223@indy.delorie.com> References: <200012261042.LAA19117@sunchorus.France.Sun.COM> <2110-Tue26Dec2000184743+0200-eliz@is.elta.co.il> <20001226150540.A7688@disaster.jaj.com> X-SW-Source: 2000-12/msg00261.html Content-length: 567 > Date: Tue, 26 Dec 2000 15:05:40 -0500 > From: Phil Edwards > > > > There are no quotes around the refedits variable, that > > > is the problem. > > > > Does it work in /bin/sh if you add an extra pair of quotes? If that > > helps, I will commit the change. > > It helps for me, but I don't know what that will do to other shells. Could you post diffs for a change that corrects the problem for you? As I wrote in another message today, I don't really understand why are you missing quotes, so I'd like to see an actual patch. TIA