From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1517 invoked by alias); 2 Oct 2013 17:18:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1503 invoked by uid 89); 2 Oct 2013 17:18:48 -0000 Received: from mail-ye0-f201.google.com (HELO mail-ye0-f201.google.com) (209.85.213.201) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 02 Oct 2013 17:18:48 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mail-ye0-f201.google.com Received: by mail-ye0-f201.google.com with SMTP id q3so123536yen.0 for ; Wed, 02 Oct 2013 10:18:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:cc:subject:in-reply-to :references; bh=33pW9DJ04oUt3RdsF4XI2wRNN7Sd5knRKwvxuYrIECI=; b=ZqvOBgIxSqROgBxh1VKeIftIbZK1lRwNwKf8FoNej601dj3xdaqcKDKrZC9jDjmM5D 1AEtDHeWv4RdP77vSpC2crPo2YUpPsIje4ynIoM80UgHpD9JmEYPSiOCqDwwdQBn9SsY mFs6ggPw9NvBkcRisU/bt8+thPND3lZmWsp2P8N1bkY7sUkmohOhEr/9E1ZjKCXmPpaG 1z/xZeVoSwFg4tqRN0jSdjOvkcN1x0cbegxm/MdyxDawHXOeLl8nVmxszQA8hHY63vSa 7l4FiEz+9NTqh4+ItKrUP/WYPTYhMnc3u6RjKaIiOnjwBpL7zwVWRrSf8xKdbge2ILBu Q3Vg== X-Gm-Message-State: ALoCoQn3DD8qGdPOrK4e3f6lznojh4Q4Zj0HO3kJT5IEZ0RILKtO/XHpChobF3I1q+3CcdczZ1LQaRsSbUztwnTRvKL5ybeWJnCKGVZLgax4BhyadLEQwZ956gyaRe3D6a8yVMVX62err0VnTu8T7CeA8CETF8/DqwlNXLuGaWzmpg7C1cdLxpPVXbUXzEIs3fZXr5qxS4cp2qyIFOG5jYCqizjGtmjGXQ== X-Received: by 10.236.53.70 with SMTP id f46mr2823144yhc.17.1380734324851; Wed, 02 Oct 2013 10:18:44 -0700 (PDT) Received: from corp2gmr1-1.hot.corp.google.com (corp2gmr1-1.hot.corp.google.com [172.24.189.92]) by gmr-mx.google.com with ESMTPS id a42si126723yhj.6.1969.12.31.16.00.00 (version=TLSv1.1 cipher=AES128-SHA bits=128/128); Wed, 02 Oct 2013 10:18:44 -0700 (PDT) Received: from ruffy.mtv.corp.google.com (ruffy.mtv.corp.google.com [172.17.128.44]) by corp2gmr1-1.hot.corp.google.com (Postfix) with ESMTP id 4BBBD31C1D9; Wed, 2 Oct 2013 10:18:44 -0700 (PDT) From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21068.21875.734416.904684@ruffy.mtv.corp.google.com> Date: Wed, 02 Oct 2013 17:18:00 -0000 To: Yao Qi Cc: Subject: Re: [PATCH 5/7] New lang-varobj.h In-Reply-To: <1379512482-31773-6-git-send-email-yao@codesourcery.com> References: <1379512482-31773-1-git-send-email-yao@codesourcery.com> <1379512482-31773-6-git-send-email-yao@codesourcery.com> X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00101.txt.bz2 Yao Qi writes: > This patch moves 'struct language_specific' out of varobj.c to a new file > 'lang-varobj.h'. > > gdb: > > 2013-09-18 Yao Qi > > * Makefile.in (HFILES_NO_SRCDIR): Add lang-varobj.h. > * lang-varobj.h: New. > * varobj.c: Include "lang-varobj.h". > (struct varobj_root): : Update its type. > (struct language_specific): Move it to lang-varobj.h. Hi. How about move lang-varobj.h into varobj.h? [setting aside general discussions of the approach for a different thread ...]